Merge lp:~aacid/unity8/40-50-90-dash into lp:unity8

Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~aacid/unity8/40-50-90-dash
Merge into: lp:unity8
Prerequisite: lp:~mzanetti/unity8/40-50-90
Diff against target: 51 lines (+20/-6)
2 files modified
qml/Dash/CardTool.qml (+15/-6)
qml/Dash/GenericScopeView.qml (+5/-0)
To merge this branch: bzr merge lp:~aacid/unity8/40-50-90-dash
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity Team Pending
Review via email: mp+263536@code.launchpad.net

Commit message

dummy message. to be changed before landing (silo build requires it)

Description of the change

This is more a test so people can test the whole 40/50/90 experience fast probably needs better code if we're going to go with it.

See pre-requisite for testing instructions.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

1838. By Albert Astals Cid

Some quick fiddling with sizes to have a 40/50/90gu prototype for the Dash

1837. By Michael Zanetti

fix greeter not being swipable from the edge

1836. By Michael Zanetti

revert bad change

1835. By Michael Zanetti

fixes

1834. By Michael Zanetti

fix mouse event eater in launcher

1833. By Michael Zanetti

restrict viewport to 40, 50 or 90 gu

1832. By Michael Zanetti

merge orientedShellFixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/CardTool.qml'
2--- qml/Dash/CardTool.qml 2015-05-13 10:24:18 +0000
3+++ qml/Dash/CardTool.qml 2015-07-01 15:43:51 +0000
4@@ -80,16 +80,25 @@
5
6 If undefined, should use implicit width of the actual card.
7 */
8- readonly property var cardWidth: {
9+ property var cardWidth: {
10 switch (categoryLayout) {
11 case "grid":
12 case "vertical-journal":
13- if (template["card-layout"] === "horizontal") return units.gu(38);
14- switch (template["card-size"]) {
15- case "small": return units.gu(12);
16- case "large": return units.gu(38);
17+ var size = template["card-size"];
18+ if (template["card-layout"] === "horizontal") size = "large";
19+ switch (size) {
20+ case "small": {
21+ if (viewWidth == units.gu(40)) return units.gu(12);
22+ else return units.gu(14);
23+ }
24+ case "large": {
25+ if (viewWidth == units.gu(90)) return units.gu(42);
26+ else return viewWidth - units.gu(2);
27+ }
28 }
29- return units.gu(18.5);
30+ if (viewWidth == units.gu(40)) return units.gu(18);
31+ else if (viewWidth == units.gu(50)) return units.gu(23);
32+ else return units.gu(20);
33 case "carousel":
34 case "horizontal-list":
35 return carouselTool.minimumTileWidth;
36
37=== modified file 'qml/Dash/GenericScopeView.qml'
38--- qml/Dash/GenericScopeView.qml 2015-06-16 15:12:33 +0000
39+++ qml/Dash/GenericScopeView.qml 2015-07-01 15:43:51 +0000
40@@ -332,6 +332,11 @@
41 updateRanges();
42 if (scope && scope.id === "clickscope" && (categoryId === "predefined" || categoryId === "local")) {
43 // Yeah, hackish :/
44+ if (scopeView.width === units.gu(50)) {
45+ cardTool.cardWidth = units.gu(10);
46+ } else if (scopeView.width === units.gu(90)) {
47+ cardTool.cardWidth = units.gu(9);
48+ }
49 cardTool.artShapeSize = Qt.size(units.gu(8), units.gu(7.5));
50 }
51 item.cardTool = cardTool;

Subscribers

People subscribed via source and target branches