Merge lp:~aacid/unity8-session-snap/install_cursor_symlink into lp:unity8-session-snap
| Status: | Rejected |
|---|---|
| Rejected by: | Michael Terry on 2016-11-07 |
| Proposed branch: | lp:~aacid/unity8-session-snap/install_cursor_symlink |
| Merge into: | lp:unity8-session-snap |
| Diff against target: |
30 lines (+12/-0) 2 files modified
cursor-symlink/CMakeLists.txt (+7/-0) snapcraft.yaml (+5/-0) |
| To merge this branch: | bzr merge lp:~aacid/unity8-session-snap/install_cursor_symlink |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | 2016-11-07 | Needs Information on 2016-11-07 | |
|
Review via email:
|
|||
Commit Message
Install the index.theme cursor shortcut theme
In the deb world this is done by the post-install of the dmz-cursor-theme package but there's no such thing in as post-install rules in snap so bascally this "by hand"
| Albert Astals Cid (aacid) wrote : | # |
No idea, documentation about that .links file is either nonexistent or impossible to find, so i don't know what that MR actually does.
| Michael Terry (mterry) wrote : | # |
Albert, good find! Thanks.
(That links file is read by dh_link. So a man page does exist. But you have to know its name first... But basically it just creates symlinks.)
I think here, we can do a simpler thing. the contents of snaphelpers/ just gets copied into the root of the snap. So we can put a snaphelpers/
I haven't tested that, I'm trying to fix another thing right this second, but I can test and add that to the branch if it works.
| Michael Terry (mterry) wrote : | # |
OK, I tested the simpler "copy the symlink into place" approach above and it worked. Thanks for the debugging Albert.
I've pushed the symlink change to trunk; I'll mark this MP as rejected.
Unmerged revisions
- 45. By Albert Astals Cid on 2016-11-07
-
Install the index.theme cursor shortcut theme

Probably correct, but what about this solution? https:/ /code.launchpad .net/~mterry/ unity8- desktop- session/ accountsservice /+merge/ 310005