Merge lp:~aacid/unity8-session-snap/install_cursor_symlink into lp:unity8-session-snap

Proposed by Albert Astals Cid on 2016-11-07
Status: Rejected
Rejected by: Michael Terry on 2016-11-07
Proposed branch: lp:~aacid/unity8-session-snap/install_cursor_symlink
Merge into: lp:unity8-session-snap
Diff against target: 30 lines (+12/-0)
2 files modified
cursor-symlink/CMakeLists.txt (+7/-0)
snapcraft.yaml (+5/-0)
To merge this branch: bzr merge lp:~aacid/unity8-session-snap/install_cursor_symlink
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) 2016-11-07 Needs Information on 2016-11-07
Review via email: mp+310169@code.launchpad.net

Commit Message

Install the index.theme cursor shortcut theme

In the deb world this is done by the post-install of the dmz-cursor-theme package but there's no such thing in as post-install rules in snap so bascally this "by hand"

To post a comment you must log in.
Lukáš Tinkl (lukas-kde) wrote :
review: Needs Information
Albert Astals Cid (aacid) wrote :

No idea, documentation about that .links file is either nonexistent or impossible to find, so i don't know what that MR actually does.

Michael Terry (mterry) wrote :

Albert, good find! Thanks.

(That links file is read by dh_link. So a man page does exist. But you have to know its name first... But basically it just creates symlinks.)

I think here, we can do a simpler thing. the contents of snaphelpers/ just gets copied into the root of the snap. So we can put a snaphelpers/usr/share/icons/default/index.theme symlink in there and it will just work.

I haven't tested that, I'm trying to fix another thing right this second, but I can test and add that to the branch if it works.

Michael Terry (mterry) wrote :

OK, I tested the simpler "copy the symlink into place" approach above and it worked. Thanks for the debugging Albert.

I've pushed the symlink change to trunk; I'll mark this MP as rejected.

Unmerged revisions

45. By Albert Astals Cid on 2016-11-07

Install the index.theme cursor shortcut theme

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'cursor-symlink'
2=== added file 'cursor-symlink/CMakeLists.txt'
3--- cursor-symlink/CMakeLists.txt 1970-01-01 00:00:00 +0000
4+++ cursor-symlink/CMakeLists.txt 2016-11-07 10:18:24 +0000
5@@ -0,0 +1,7 @@
6+cmake_minimum_required(VERSION 2.8)
7+
8+project(cursor-symlink)
9+
10+set(CMAKE_VERBOSE_MAKEFILE ON)
11+
12+install(FILES index.theme DESTINATION usr/share/icons/default/)
13
14=== added symlink 'cursor-symlink/index.theme'
15=== target is u'../DMZ-White/cursor.theme'
16=== modified file 'snapcraft.yaml'
17--- snapcraft.yaml 2016-10-27 14:57:36 +0000
18+++ snapcraft.yaml 2016-11-07 10:18:24 +0000
19@@ -147,6 +147,11 @@
20 - gschema-compile
21 plugin: dump
22 source: snaphelpers
23+ cursor-symlink:
24+ after:
25+ - snappyhelpers
26+ plugin: cmake
27+ source: cursor-symlink
28
29 apps:
30 unity8-session:

Subscribers

People subscribed via source and target branches