Merge lp:~aacid/unity/jenkins_mesa_dri into lp:unity/phablet

Proposed by Albert Astals Cid
Status: Merged
Approved by: Albert Astals Cid
Approved revision: no longer in the source branch.
Merged at revision: 659
Proposed branch: lp:~aacid/unity/jenkins_mesa_dri
Merge into: lp:unity/phablet
Diff against target: 31 lines (+3/-0)
2 files modified
debian/control (+1/-0)
tests/qmltests/Dash/tst_PeoplePreview.qml (+2/-0)
To merge this branch: bzr merge lp:~aacid/unity/jenkins_mesa_dri
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ying-Chun Liu (community) Approve
Gerry Boland (community) Approve
Michael Zanetti (community) Approve
Review via email: mp+162377@code.launchpad.net

Commit message

Qt declarative needs libgl1-mesa-dri on runtime

Add it to our build depends so the tests do actually pass on jenkins

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

Works for me.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-04-25 18:50:40 +0000
3+++ debian/control 2013-05-07 10:21:28 +0000
4@@ -11,6 +11,7 @@
5 libboost1.49-dev (>= 1.49),
6 libdee-qt5-dev (>= 3.0),
7 libgl1-mesa-dev[!armhf] | libgl-dev[!armhf],
8+ libgl1-mesa-dri,
9 libgles2-mesa-dev[armhf],
10 libgtest-dev,
11 libhud-client2-dev,
12
13=== modified file 'tests/qmltests/Dash/tst_PeoplePreview.qml'
14--- tests/qmltests/Dash/tst_PeoplePreview.qml 2013-05-03 22:23:27 +0000
15+++ tests/qmltests/Dash/tst_PeoplePreview.qml 2013-05-07 10:21:28 +0000
16@@ -225,6 +225,7 @@
17 }
18
19 function verifyClick(field) {
20+ waitForRendering(field)
21 clickSpy.signalName = "" // Get rid of a warning if new target doesn't support previous signal name
22 clickSpy.target = field;
23 clickSpy.clear();
24@@ -235,6 +236,7 @@
25 }
26
27 function verifyPhoneNumberClick(field) {
28+ waitForRendering(field)
29 clickSpy.target = field;
30 clickSpy.clear();
31 clickSpy.signalName = "phoneClicked";

Subscribers

People subscribed via source and target branches