Unity

Merge lp:~aacid/unity/initialize_using_nofilters_background_6.0 into lp:unity/6.0

  1. initialize_using_nofilters_background_6.0
  2. Merge into 6.0
Proposed by Albert Astals Cid on 2012-10-31
Status: Rejected
Rejected by: Albert Astals Cid on 2012-11-15
Proposed branch: lp:~aacid/unity/initialize_using_nofilters_background_6.0
Merge into: lp:unity/6.0
Diff against target: 11 lines (+1/-0)
1 file modified
dash/PlacesGroup.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity/initialize_using_nofilters_background_6.0
Reviewer Review Type Date Requested Status
Gord Allott 2012-10-31 Pending
Review via email: mp+132297@code.launchpad.net

Commit Message

Initialize _using_nofilters_background to true

It is the correct value according to Gord

Description of the Change

Initialize _using_nofilters_background to true

It is the correct value according to Gord

To post a comment you must log in.
Albert Astals Cid (aacid) wrote :
Timo Jyrinki (timo-jyrinki) wrote :

I'd think that since Unity can be considered part of infrastructure, and the fix isn't clearly fixing a high impact bug, it doesn't fall under SRUable commits. That could change if there was a clear user problem because of this bug.

Marco Trevisan (Treviño) (3v1n0) wrote :

Very likely this can lead to a bug... So, we only have to find it. :)

Unmerged revisions

2793. By Albert Astals Cid on 2012-10-31

Initialize _using_nofilters_background to true

It is the correct value according to Gord

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/PlacesGroup.cpp'
2--- dash/PlacesGroup.cpp 2012-10-08 16:19:10 +0000
3+++ dash/PlacesGroup.cpp 2012-10-31 11:07:50 +0000
4@@ -114,6 +114,7 @@
5 : AbstractPlacesGroup(),
6 _style(style),
7 _child_view(nullptr),
8+ _using_nofilters_background(true),
9 _is_expanded(false),
10 _n_visible_items_in_unexpand_mode(0),
11 _n_total_items(0),

Subscribers

People subscribed via source and target branches