Merge lp:~aacid/unity/ignore_unmapped_on_minimize_unminimize into lp:unity

Proposed by Albert Astals Cid on 2012-10-02
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2012-10-02
Approved revision: no longer in the source branch.
Merged at revision: 2786
Proposed branch: lp:~aacid/unity/ignore_unmapped_on_minimize_unminimize
Merge into: lp:unity
Diff against target: 21 lines (+2/-2)
1 file modified
plugins/unityshell/src/compizminimizedwindowhandler.h (+2/-2)
To merge this branch: bzr merge lp:~aacid/unity/ignore_unmapped_on_minimize_unminimize
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2012-10-02 Approve on 2012-10-02
Review via email: mp+127460@code.launchpad.net

Commit Message

Ignore transient unmmaped windows on minimize/unminimize

Doesn't make much sense since they are not shown and it confuses Qt code

Description of the Change

Ignore transient unmmaped windows on minimize/unminimize

Doesn't make much sense since they are not shown and it confuses Qt code

To post a comment you must log in.
2781. By Maxim Ermilov on 2012-10-02

BamfLauncherIcon: use bamf provided mime types.. Fixes: . Approved by Marco Trevisan (Treviño).

2782. By Nick Dedekind on 2012-10-02

Removed minimum width from result group causing home lens not to wrap. (LP#1053116). Fixes: https://bugs.launchpad.net/bugs/1053116. Approved by Gord Allott.

2783. By Nick Dedekind on 2012-10-02

Immediate feedback for dash preview activation.. Fixes: https://bugs.launchpad.net/bugs/1043808. Approved by Gord Allott, Brandon Schaefer.

Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, fine... Please backport this also for 5.0 (if affected) and 6.0.

review: Approve
2784. By Paweł Stołowski on 2012-10-02

Uploaded correct (hires) icon for missing album artwork when displaying music preview.. Fixes: https://bugs.launchpad.net/bugs/1060195. Approved by Jussi Pakkanen.

2785. By Stephen M. Webb on 2012-10-02

dash/StandaloneDash.cpp: added animator so previews will display. Fixes: . Approved by Marco Trevisan (Treviño).

2786. By Albert Astals Cid on 2012-10-02

Ignore transient unmmaped windows on minimize/unminimize

Doesn't make much sense since they are not shown and it confuses Qt code. Fixes: https://bugs.launchpad.net/bugs/929712. Approved by Marco Trevisan (Treviño).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/compizminimizedwindowhandler.h'
2--- plugins/unityshell/src/compizminimizedwindowhandler.h 2012-06-27 20:45:24 +0000
3+++ plugins/unityshell/src/compizminimizedwindowhandler.h 2012-10-02 11:30:31 +0000
4@@ -154,7 +154,7 @@
5 {
6 CompWindow *win = screen->findWindow (w);
7
8- if (win)
9+ if (win && win->isMapped())
10 {
11 Window *w = Window::get (win);
12 if (!w->mMinimizeHandler)
13@@ -235,7 +235,7 @@
14 {
15 CompWindow *win = screen->findWindow (w);
16
17- if (win)
18+ if (win && win->isMapped())
19 {
20 Window *w = Window::get (win);
21 if (w && w->mMinimizeHandler)