Merge lp:~aacid/unity/do_not_show_unsensitive_menu into lp:unity

[Albert Astals Cid]

Do not show the menu if it is not sensitive when moving the mouse after opening a sensitive menu

Do not show the menu if it is not sensitive.

As the bug says: If you have a disabled toplevel menu entry clicking on it does not open the menu, but if you open a different menu and then move the mouse over the disabled one it will get opened.

[Thomi Richards (thomir-deactivatedaccount)]

Nice fix - thanks!

I've verified that this works as expected. We'd love to have an autopilot test, or at least a manual test.

Can you find an application in the base Ubuntu install that has a disabled top level menu, and write a manual test in the unity source tree please?

With a manual test I'm happy to merge this.

Cheers,

review: Needs Fixing

[Albert Astals Cid (aacid)]

I thought we would have a test for this already since the regular case, i.e. If you have a disabled toplevel menu entry clicking on it does not open the menu, already works without this patch.

This patch only fixes the fact that if you open a different menu (non disabled) and then move the mouse over the disabled one it will get opened.

[Albert Astals Cid (aacid)]

Have been searching for a while and could not find any program in the default ubuntu install that has disabled top level menus.

[Albert Astals Cid (aacid)]

Not in the default install, but qtcreator "Build" menu is disabled if no project is open (i.e. just after opening it)

[Albert Astals Cid (aacid)]

The "Go" menu in gnome-dictionary is also disabled.

Without this patch you can
 * Click on Go in the menu
 * See the menu does not open (this is correct)
 * Click on Help in the menu
 * Move over the Go menu
 * See how the Go menu opens (this is wrong)

If you use the patch the wrong part gets fixed

=== modified file 'panel/PanelIndicatorsView.cpp'
--- panel/PanelIndicatorsView.cpp	2012-05-06 23:48:38 +0000
+++ panel/PanelIndicatorsView.cpp	2012-05-25 13:44:15 +0000
@@ -222,6 +222,7 @@
     PanelIndicatorEntryView* view = entry.second;
 
     if (!target && view->IsVisible() && view->IsFocused() &&
+        view->IsSensitive() &&
         view->GetAbsoluteGeometry().IsPointInside(x, y))
     {
       view->Activate(button);