unity-scopes-shell

Merge lp:~aacid/unity-scopes-shell/save_creation_deletion_of_QSharedPointer into lp:unity-scopes-shell

  1. save_creation_deletion_of_QSharedPointer
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 338
Merged at revision: 348
Proposed branch: lp:~aacid/unity-scopes-shell/save_creation_deletion_of_QSharedPointer
Merge into: lp:unity-scopes-shell
Diff against target: 12 lines (+1/-1)
1 file modified
src/Unity/categories.cpp (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity-scopes-shell/save_creation_deletion_of_QSharedPointer
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+300882@code.launchpad.net

Commit message

Save creating/destroying a QSharedPointer

It's not much but it's a free optimization anyway

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Unity/categories.cpp'
2--- src/Unity/categories.cpp 2016-03-29 14:31:01 +0000
3+++ src/Unity/categories.cpp 2016-07-22 13:10:04 +0000
4@@ -538,7 +538,7 @@
5 return QVariant();
6 }
7
8- QSharedPointer<CategoryData> catData = m_categories.at(row);
9+ const QSharedPointer<CategoryData> &catData = m_categories.at(row);
10
11 if (!catData)
12 {

Subscribers

People subscribed via source and target branches

to all changes: