lp:~aacid/unity-scopes-shell/misc_fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-scopes-shell at revision 356

Marcus Tomlinson (community): Approve on 2016-12-23

unity-api-1-bot: Approve (continuous-integration) on 2016-12-23

Diff: 89 lines (+5/-8)

7 files modified

src/Unity/optionselectoroptions.h (+1/-1)
src/Unity/overviewscope.cpp (+1/-1)
src/Unity/settingsmodel.cpp (+0/-1)
src/scope-harness/preview/preview-widget.h (+1/-1)
tests/data/mock-scope-departments/mock-scope-departments.cpp (+1/-1)
tests/data/mock-scope/mock-scope.cpp (+1/-1)
tests/resultstest.cpp (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

356. By Albert Astals Cid on 2016-12-23

Misc fixes

preview-widget.h
optionselectoroptions.h
 Forward declare as struct as it is really a struct when defined

overviewscope.cpp
 Save creating a list with all the values since foreach knows how to properly iterate a map/hash

settingsmodel.cpp
resultstest.cpp
 Don't create an object we never use

mock-scope-departments.cpp
/mock-scope.cpp
 Mark function as override

355. By Launchpad Translations on behalf of unity-team on 2016-12-21

Launchpad automatic translations update.

354. By Launchpad Translations on behalf of unity-team on 2016-11-23

Launchpad automatic translations update.

353. By CI Train Bot Account on 2016-11-15

Releasing 0.5.8+17.04.20161115.3-0ubuntu1

352. By Michael Terry on 2016-11-15

Handle running inside a snap by paying attention to the $SNAP prefix. (LP: #1629009)

Approved by: Marcus Tomlinson, unity-api-1-bot

351. By Launchpad Translations on behalf of unity-team on 2016-10-12

Launchpad automatic translations update.

350. By CI Train Bot Account on 2016-10-04

Releasing 0.5.8+16.10.20161004-0ubuntu1

349. By Marcus Tomlinson on 2016-10-04

Don't make changes to the settings model from a separate thread. (LP: #1627795)

348. By Albert Astals Cid on 2016-10-04

Save creating/destroying a QSharedPointer

It's not much but it's a free optimization anyway

Approved by: Paweł Stołowski

347. By Albert Astals Cid on 2016-10-04

Optimize ResultsModel::data a bit

Do the role to component string early in ::setComponentsMapping instead of every time in ::data
This way we do not need to create temporary strings every time ::data gets called

Also since we know there's a finite amount of roles, store the role->string mapping in a vector instead of a map/hash

Approved by: Marcus Tomlinson