Merge lp:~aacid/unity-scopes-api/cmakewarnings into lp:unity-scopes-api

[Albert Astals Cid]

Fix CMake warnings

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:262
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/477/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/477/rebuild

review: Approve (continuous-integration)

[Michi Henning (michihenning)]

I checked in a fix for this recently already, to devel, but that fix maybe hasn't merged yet? Were you building from trunk or from devel?

You get the warnings due to a change in behaviour in cmake, added with 3.0.2.

Adding this dependency to the top-level CMakeLists.txt isn't the right thing because libunity-scopes-api doesn't use these libs; only the static library for the smartscopesproxy does and, for that, the dependency is already in place.

If you grab devel, you won't see the warning any longer. I'd like to change cmake_minimum_required() to 3.0.2 but, last time I looked, that wasn't available on Jenkins.

review: Needs Information

[Albert Astals Cid (aacid)]

I am using trunk, no idea there's a devel branch :) Trunk has always sounded devel enough to me :D

Yes the warning is gone in devel

Unmerged revisions

262. By Albert Astals Cid on 2014-11-26

Fix CMake warnings

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-10-22 15:46:36 +0000
+++ CMakeLists.txt	2014-11-26 11:08:14 +0000
@@ -61,6 +61,8 @@
 
 include(FindPkgConfig)
 find_package(Boost COMPONENTS system filesystem regex serialization REQUIRED)
+find_package(Qt5Core 5.3 REQUIRED)
+find_package(Qt5Network 5.3 REQUIRED)
 pkg_check_modules(UNITY_API libunity-api>=0.1.3 REQUIRED)
 pkg_check_modules(PROCESS_CPP process-cpp>=1.0.1 REQUIRED)
 pkg_check_modules(APPARMOR REQUIRED libapparmor REQUIRED)