Merge lp:~aacid/unity-scope-click/no_overlay_color into lp:unity-scope-click

[Albert Astals Cid]

Set the overlay color to transparent

We just want the text, not the gray-ish overlay

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:383
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/676/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/82
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/78
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/78/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/676/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

Yes!

review: Approve

[dobey (dobey)]

Is there a bug for this? I don't quite understand what this does exactly. Also, if you want this released on the phone, you'll need a separate MP into lp:unity-scope-click/touch-15-04 as dual landings aren't used for unity-scope-click.

review: Needs Information

[Albert Astals Cid (aacid)]

> Is there a bug for this? I don't quite understand what this does exactly.
> Also, if you want this released on the phone, you'll need a separate MP into
> lp:unity-scope-click/touch-15-04 as dual landings aren't used for unity-scope-
> click.

As explained on IRC new unity8 fixes a bug you were "exploiting" to get no background on the overlay, now (with silo 21) to get no background on the overlay we need to properly set it to transparent

[Albert Astals Cid (aacid)]

https://code.launchpad.net/~aacid/unity-scope-click/no_overlay_color_1504/+merge/276548 for the 15.04 branch one.

[dobey (dobey)]

review: Approve

=== modified file 'scope/clickapps/apps-query.cpp'
--- scope/clickapps/apps-query.cpp	2014-08-19 21:20:18 +0000
+++ scope/clickapps/apps-query.cpp	2015-11-03 10:42:38 +0000
@@ -81,7 +81,8 @@
     "art": {
       "aspect-ratio": 0.55,
       "field": "art"
-    }
+    },
+    "overlay-color": "overlay-color"
   }
 }
 
@@ -289,6 +290,7 @@
     res[click::apps::Query::ResultKeys::MAIN_SCREENSHOT] = "";
     res[click::apps::Query::ResultKeys::INSTALLED] = true;
     res[click::apps::Query::ResultKeys::VERSION] = "";
+    res["overlay-color"] = "transparent";
     searchReply->push(res);
 }