Merge lp:~aacid/unity-greeter/do_not_use_rls_cache_on_error_retry into lp:unity-greeter

Proposed by Albert Astals Cid
Status: Merged
Merged at revision: 582
Proposed branch: lp:~aacid/unity-greeter/do_not_use_rls_cache_on_error_retry
Merge into: lp:unity-greeter
Diff against target: 16 lines (+5/-1)
1 file modified
src/user-list.vala (+5/-1)
To merge this branch: bzr merge lp:~aacid/unity-greeter/do_not_use_rls_cache_on_error_retry
Reviewer Review Type Date Requested Status
Unity Greeter Development Team Pending
Review via email: mp+124621@code.launchpad.net

Commit message

Do not use the R-L-S cache when retrying user and password and had an error

Description of the change

Do not use the R-L-S cache when retrying user and password and had an error

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/user-list.vala'
2--- src/user-list.vala 2012-09-12 14:32:39 +0000
3+++ src/user-list.vala 2012-09-17 08:45:35 +0000
4@@ -401,7 +401,11 @@
5 else
6 {
7 string data_type;
8- yield remote_login_service.get_servers_for_login (url, email, password_field.text, true, out login_success, out data_type, out server_list);
9+ bool allowcache = true;
10+ // If we had an error and are retrying the same user and server, do not use the cache on R-L-S
11+ if (selected_entry.has_errors && currently_browsing_server_email == email && currently_browsing_server_url == url)
12+ allowcache = false;
13+ yield remote_login_service.get_servers_for_login (url, email, password_field.text, allowcache, out login_success, out data_type, out server_list);
14 }
15 currently_browsing_server_url = url;
16 currently_browsing_server_email = email;

Subscribers

People subscribed via source and target branches