Merge lp:~aacid/unity-api/cmake_warning-- into lp:unity-api

[Albert Astals Cid]

Avoid cmake warnings

    CMake Warning (dev) in CMakeLists.txt:
      Syntax Warning in cmake code at

        /home/tsdgeos_work/phablet/unity-api/unity-api/CMakeLists.txt:53:88

      Argument not separated from preceding token by whitespace.
    This warning is for project developers. Use -Wno-dev to suppress it.

    CMake Warning (dev) in CMakeLists.txt:
      Syntax Warning in cmake code at

        /home/tsdgeos_work/phablet/unity-api/unity-api/CMakeLists.txt:53:107

      Argument not separated from preceding token by whitespace.
    This warning is for project developers. Use -Wno-dev to suppress it.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:111
http://jenkins.qa.ubuntu.com/job/unity-api-ci/130/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-i386-ci/4

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-api-ci/130/rebuild

review: Approve (continuous-integration)

[Michi Henning (michihenning)]

I haven't seen this before, at least not with cmake 2.8.11.2.

What version of cmake is this happening with?

[Albert Astals Cid (aacid)]

cmake 2.8.12

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-api-autolanding/63/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/3193/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-amd64-autolanding/2
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-autolanding/2/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-autolanding/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-i386-autolanding/2

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://jenkins.qa.ubuntu.com/job/unity-api-autolanding/64/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-amd64-autolanding/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-autolanding/3
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-armhf-autolanding/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-trusty-i386-autolanding/3

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2013-10-18 02:33:12 +0000
+++ CMakeLists.txt	2013-11-06 14:26:29 +0000
@@ -50,11 +50,12 @@
 find_program(CPPCHECK_COMMAND NAMES cppcheck)
 if (CPPCHECK_COMMAND)
     set(CPPCHECK_COMMAND_OPTIONS --check-config --inline-suppr --enable=all -q --error-exitcode=2)
-    set(CPPCHECK_COMMAND_OPTIONS ${CPPCHECK_COMMAND_OPTIONS} --template '{file}({line}): {severity} ({id}): {message}')
+    set(CPPCHECK_COMMAND_OPTIONS ${CPPCHECK_COMMAND_OPTIONS} --template "{file}({line}): {severity} ({id}): {message}")
     add_custom_target(cppcheck COMMAND ${CPPCHECK_COMMAND} ${CPPCHECK_COMMAND_OPTIONS}
         ${CMAKE_SOURCE_DIR}/src
         ${CMAKE_SOURCE_DIR}/test
         ${CMAKE_BINARY_DIR}/test
+        VERBATIM
     )
 else()
     message(WARNING "Cannot find cppcheck: cppcheck target will not be available")