Merge lp:~aacid/unity-2d/unity-2d_test_mouse_timing_tests into lp:unity-2d

[Albert Astals Cid]

[test] Small improvements to autohide tests regarding timing on mouse moves

[Gerry Boland (gerboland)]

Hey,
you're gonna kill me, but I've a MR with this whole test re-done using the verify* methods.
https://code.launchpad.net/~gerboland/unity-2d/rewrite-launcher-autohide-show-test/+merge/88969

I did this because all the sleep statements made the test very unreliable. Merging this now will just make the situation worse, so I'm hoping that if my MR is accepted, you can modify this to take advantage of the verify* methods too.
-G

[lp:~aacid/unity-2d/unity-2d_test_mouse_timing_tests]

852. By Albert Astals Cid on 2012-01-18

Merge trunk

[Gerry Boland (gerboland)]

Thank you for updating this test. Approved

review: Approve

=== modified file 'tests/launcher/autohide_show_tests.rb'
--- tests/launcher/autohide_show_tests.rb	2012-01-18 11:01:20 +0000
+++ tests/launcher/autohide_show_tests.rb	2012-01-18 12:14:29 +0000
@@ -179,11 +179,11 @@
   #   * Open application in position overlapping Launcher
   #   * Verify Launcher hiding
   #   * Move mouse to left of screen to reveal Launcher
-  #   * Verify Launcher shows
+  #   * Verify Launcher shows but not immediately
   #   * Move mouse to the right, but still over the Launcher
   #   * Verify Launcher still showing
   #   * Move mouse further right to not overlap Launcher
-  #   * Verify Launcher hides
+  #   * Verify Launcher hides but not immediately
   # Post-conditions
   #   * None
   # References
@@ -195,6 +195,10 @@
     }
 
     XDo::Mouse.move(0,200)
+    sleep 0.4
+    verify_equal( -WIDTH, 0, 'Launcher should not be visible immediately after mouse moves to the left edge, has to wait 0.5 seconds to show' ) {
+      @app.Unity2dPanel()['x_absolute'].to_i
+    }
     verify_equal( 0, TIMEOUT, 'Launcher hiding when mouse at left edge of screen' ) {
       @app.Unity2dPanel()['x_absolute'].to_i
     }
@@ -205,6 +209,10 @@
     }
 
     XDo::Mouse.move(WIDTH,200)
+    sleep 0.9
+    verify_equal( 0, 0, 'Launcher should still be visible as it should take 1 second to hide after mouse is not over it' ) {
+      @app.Unity2dPanel()['x_absolute'].to_i
+    }
     verify_equal( -WIDTH, TIMEOUT, 'Launcher visible with window in the way and mouse moved out, should be hidden' ) {
       @app.Unity2dPanel()['x_absolute'].to_i
     }