Merge lp:~aacid/unity-2d/unity-2d_test_dash_launcher_interactions into lp:unity-2d

[Albert Astals Cid]

[Test] Check Super, Alt+F1 interaction and Super, Super, Alt+F1 interaction

[Gerry Boland (gerboland)]

You are settings many of the verify timeouts to zero. Bear in mind that the purpose of these timeouts is to give some lee-way for old/show machines or those under load from other processes at test time.

If the verify condition is true, it will return immediately. Otherwise it waits for a period (timeout) until the condition is correct, and throws fail exception is the timeout expires.

This is why asserts are not good for app testing.

I think it good to give generous timeouts to all verify statements, only exception being if you are checking on the timing of a particular condition becoming true (and those nested verify thingys).

I'm guessing it's why I got this error, as the test should pass:

Verification "Launcher should be showing after pressing Alt+F1" at ./places/places-tests.rb:202:in `test_Super__Super_and_Alt_F1_interaction' failed as an exception was thrown when the verification block was executed
=> verify_not(0, 'Launcher should be showing after pressing Alt+F1') {
         verify_true( 1 ) {
           @app_launcher.Unity2dPanel()['x_absolute'].to_i != 0

Details:
#<TypeError: exception object expected>

review: Needs Fixing

[Gerry Boland (gerboland)]

Also
+ WIDTH = 65
gives me a warning.

Today I just learned that defining a constant in a class in Ruby defines it globally, not just in the class :)

So we need to fix up constants. We should add a file with basic constants: LAUNCHER_WIDTH, PANEL_HEIGHT, DASH_WIDTH, etc.. which we can reference everywhere.

[Albert Astals Cid (aacid)]

The timeouts to 0 are for the same conditions that exist in the previous tests already.

Actually i'm confused about the message you get, it says "an exception was thrown when the verification block was executed", well that's exactly when verify_not is supposed to succeed, isn't it?

About the WIDTH thing do you want me to create a separate MR for that?

[Gerry Boland (gerboland)]

> The timeouts to 0 are for the same conditions that exist in the previous tests already.

+ XDo::Keyboard.alt_F1 #Must use uppercase F to indicate function keys
+ verify_not(0, 'There should not be a Dash declarative view after pressing Alt+F1') {
+ @app_places.DashDeclarativeView()
+ }

Yep I see what you mean, but taking the above, if it takes the program a second to react to Alt+F1 and destroy the DashDeclarativeView, the verify_not will have already timed out and thrown a fail.

I'm encouraging TIMEOUTs as much as possible. They cause no harm, do they?

[Gerry Boland (gerboland)]

> Actually i'm confused about the message you get, it says "an exception was thrown
> when the verification block was executed", well that's exactly when verify_not is
> supposed to succeed, isn't it?

Hmm, verify_not expects an exception, else it fails. This means verify_true returned without throwing an exception, so
@app_launcher.Unity2dPanel()['x_absolute'].to_i != 0
was true at some stage.

Now exactly why that happened I'm not sure. True a longer timeout won't help in this case. Perhaps my machine is too fast, and panel respawned (maybe by gnome-session). I'll try again to be certain.

[Gerry Boland (gerboland)]

Please ignore that last sentence, I got my wires crossed :)

[Albert Astals Cid (aacid)]

The separate MR for WIDTH is at https://code.launchpad.net/~aacid/unity-2d/unity-2d_test_common_definitions/+merge/90251

[Albert Astals Cid (aacid)]

Right, the question is how/why
@app_launcher.Unity2dPanel()['x_absolute'].to_i != 0
was true at some stage during that 1 second timeout, it'd be cool if you could dig a bit more about it.

I'll try and see if adding TIMEOUTS to those 0 sec verify still makes it work for me.

[Albert Astals Cid (aacid)]

Just realized the test is wrongly written, will improve it in a sec

[Albert Astals Cid (aacid)]

pushed a new version with bigger timeouts (2 instead of 0) and with an improved test workflow

[Gerry Boland (gerboland)]

Ok, works nicely. Thanks

review: Approve

[Unity Merger (unity-merger)]

Attempt to merge into lp:unity-2d failed due to conflicts:

text conflict in tests/places/places-tests.rb

[Unity Merger (unity-merger)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

=== modified file 'tests/places/places-tests.rb'
--- tests/places/places-tests.rb	2012-01-25 17:03:58 +0000
+++ tests/places/places-tests.rb	2012-01-27 10:46:35 +0000
@@ -162,4 +162,93 @@
       }
     }
   end
+
+  # Test case objectives:
+  #   * Check Super and Alt+F1 interaction
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Verify dash is not showing
+  #   * Press Super
+  #   * Verify dash is showing
+  #   * Press Alt+F1
+  #   * Verify dash is not showing
+  #   * Verify launcher does not hide
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Super and Alt+F1 interaction" do
+    xid = TmpWindow.open_window_at(10,100)
+    verify_not(2, 'There should not be a Dash declarative view on startup') {
+      @app_places.DashDeclarativeView()
+    }
+    XDo::Keyboard.super
+    verify(TIMEOUT, 'There should be a Dash declarative view after pressing Super') {
+      @app_places.DashDeclarativeView()
+    }
+    XDo::Keyboard.alt_F1 #Must use uppercase F to indicate function keys
+    verify_not(2, 'There should not be a Dash declarative view after pressing Alt+F1') {
+      @app_places.DashDeclarativeView()
+    }
+    verify_not(0, 'Launcher should not hide after pressing Alt+F1') {
+      verify_equal( -LAUNCHER_WIDTH, 2 ) {
+        @app_launcher.Unity2dPanel()['x_absolute'].to_i
+      }
+    }
+    xid.close!
+  end
+
+  # Test case objectives:
+  #   * Check Super, Super and Alt+F1 interaction
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Verify dash is not showing
+  #   * Verify terminal has focus
+  #   * Press Super
+  #   * Verify dash is showing
+  #   * Press Super
+  #   * Verify dash is not showing
+  #   * Verify terminal has focus
+  #   * Verify launcher is hidden
+  #   * Press Alt+F1
+  #   * Verify dash is not showing
+  #   * Verify launcher shows
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Super, Super and Alt+F1 interaction" do
+    xid = TmpWindow.open_window_at(10,100)
+    verify_equal( xid.id, TIMEOUT, 'terminal should have focus after starting it' ) {
+      XDo::XWindow.active_window
+    }
+    verify_not(2, 'There should not be a Dash declarative view on startup') {
+      @app_places.DashDeclarativeView()
+    }
+    XDo::Keyboard.super
+    verify(TIMEOUT, 'There should be a Dash declarative view after pressing Super') {
+      @app_places.DashDeclarativeView()
+    }
+    XDo::Keyboard.super
+    verify_not(2, 'There should not be a Dash declarative view after pressing Super again') {
+      @app_places.DashDeclarativeView()
+    }
+    verify_equal( xid.id, TIMEOUT, 'terminal should have focus after toggling the dash' ) {
+      XDo::XWindow.active_window
+    }
+    verify_equal( -LAUNCHER_WIDTH, TIMEOUT, 'Launcher should be hiding after toggling the dash' ) {
+      @app_launcher.Unity2dPanel()['x_absolute'].to_i
+    }
+    XDo::Keyboard.alt_F1 #Must use uppercase F to indicate function keys
+    verify_not(2, 'There should not be a Dash declarative view after pressing Alt+F1') {
+      @app_places.DashDeclarativeView()
+    }
+    verify_equal( 0, TIMEOUT, 'Launcher should be showing after pressing Alt+F1' ) {
+      @app_launcher.Unity2dPanel()['x_absolute'].to_i
+    }
+    xid.close!
+  end
+
 end