Merge lp:~aacid/unity-2d/unity-2d-shell_rtl_fixed_launcher into lp:~unity-2d-team/unity-2d/unity-2d-shell

Proposed by Albert Astals Cid
Status: Merged
Approved by: Florian Boucault
Approved revision: 984
Merged at revision: 987
Proposed branch: lp:~aacid/unity-2d/unity-2d-shell_rtl_fixed_launcher
Merge into: lp:~unity-2d-team/unity-2d/unity-2d-shell
Diff against target: 30 lines (+3/-3)
1 file modified
shell/Shell.qml (+3/-3)
To merge this branch: bzr merge lp:~aacid/unity-2d/unity-2d-shell_rtl_fixed_launcher
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+92015@code.launchpad.net

Description of the change

[shell] Fix launcher position in always visible mode for RTL

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

Functionally works.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/Shell.qml'
2--- shell/Shell.qml 2012-02-08 10:55:20 +0000
3+++ shell/Shell.qml 2012-02-08 11:51:20 +0000
4@@ -40,7 +40,7 @@
5 if (Utils.isLeftToRight()) {
6 return visibilityController.shown ? 0 : -width
7 } else {
8- return visibilityController.shown ? declarativeView.screen.availableGeometry.width - width : declarativeView.screen.availableGeometry.width
9+ return visibilityController.shown ? shell.width - width : shell.width
10 }
11 }
12
13@@ -83,7 +83,7 @@
14 id: dashLoader
15 source: "dash/Dash.qml"
16 anchors.top: parent.top
17- x: Utils.isLeftToRight() ? launcherLoader.width : declarativeView.screen.availableGeometry.width - width - launcherLoader.width
18+ x: Utils.isLeftToRight() ? launcherLoader.width : shell.width - width - launcherLoader.width
19 onLoaded: item.focus = true
20 opacity: item.active ? 1.0 : 0.0
21 focus: item.active
22@@ -127,7 +127,7 @@
23 rectangle: {
24 // FIXME: this results in a 1px wide white rectangle on the launcher edge, we should switch
25 // to cpp-based edge detection, and later XFixes barriers to get rid of that completely
26- var somewhatShown = Utils.isLeftToRight() ? -launcherLoader.x < launcherLoader.width : launcherLoader.x < declarativeView.screen.availableGeometry.width
27+ var somewhatShown = Utils.isLeftToRight() ? -launcherLoader.x < launcherLoader.width : launcherLoader.x < shell.width
28 if (somewhatShown) {
29 return Qt.rect(launcherLoader.x,
30 launcherLoader.y,

Subscribers

People subscribed via source and target branches