Merge lp:~aacid/unity-2d/unity-2d-shell_inputshapemask_improvements into lp:~unity-2d-team/unity-2d/unity-2d-shell

Proposed by Albert Astals Cid
Status: Merged
Approved by: Florian Boucault
Approved revision: 987
Merged at revision: 989
Proposed branch: lp:~aacid/unity-2d/unity-2d-shell_inputshapemask_improvements
Merge into: lp:~unity-2d-team/unity-2d/unity-2d-shell
Diff against target: 43 lines (+6/-2)
2 files modified
libunity-2d-private/src/inputshapemask.cpp (+2/-0)
libunity-2d-private/src/inputshapemask.h (+4/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/unity-2d-shell_inputshapemask_improvements
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+92035@code.launchpad.net

Description of the change

Add sourceChanged and colorChanged signals to InputShapeMask

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libunity-2d-private/src/inputshapemask.cpp'
2--- libunity-2d-private/src/inputshapemask.cpp 2012-02-07 20:19:29 +0000
3+++ libunity-2d-private/src/inputshapemask.cpp 2012-02-08 14:06:20 +0000
4@@ -78,6 +78,7 @@
5 {
6 if (m_source != source) {
7 m_source = source;
8+ Q_EMIT sourceChanged(m_source);
9 updateShape();
10 }
11 }
12@@ -86,6 +87,7 @@
13 {
14 if (m_color != color) {
15 m_color = color;
16+ Q_EMIT colorChanged(m_color);
17 updateShape();
18 }
19 }
20
21=== modified file 'libunity-2d-private/src/inputshapemask.h'
22--- libunity-2d-private/src/inputshapemask.h 2012-02-07 20:19:29 +0000
23+++ libunity-2d-private/src/inputshapemask.h 2012-02-08 14:06:20 +0000
24@@ -30,8 +30,8 @@
25 class InputShapeMask : public QObject
26 {
27 Q_OBJECT
28- Q_PROPERTY(QString source READ source WRITE setSource)
29- Q_PROPERTY(QColor color READ color WRITE setColor)
30+ Q_PROPERTY(QString source READ source WRITE setSource NOTIFY sourceChanged)
31+ Q_PROPERTY(QColor color READ color WRITE setColor NOTIFY colorChanged)
32 Q_PROPERTY(QPoint position READ position WRITE setPosition NOTIFY positionChanged)
33 Q_PROPERTY(QBitmap shape READ shape NOTIFY shapeChanged)
34 Q_PROPERTY(bool enabled READ enabled WRITE setEnabled NOTIFY enabledChanged)
35@@ -51,6 +51,8 @@
36 void setEnabled(bool enabled);
37
38 Q_SIGNALS:
39+ void sourceChanged(const QString& source);
40+ void colorChanged(const QColor& color);
41 void enabledChanged();
42 void shapeChanged();
43 void positionChanged();

Subscribers

People subscribed via source and target branches