Merge lp:~aacid/unity-2d/unity-2d-shell_fix_bfb_toggling into lp:~unity-2d-team/unity-2d/unity-2d-shell

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michał Sawicz
Approved revision: 921
Merged at revision: 923
Proposed branch: lp:~aacid/unity-2d/unity-2d-shell_fix_bfb_toggling
Merge into: lp:~unity-2d-team/unity-2d/unity-2d-shell
Diff against target: 15 lines (+4/-2)
1 file modified
shell/launcher/IntelliHideBehavior.qml (+4/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/unity-2d-shell_fix_bfb_toggling
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Ugo Riboni Pending
Review via email: mp+89259@code.launchpad.net

Description of the change

[launcher] Only start the leave timer on visibility change if the mouse is not on the launcher

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :
921. By Albert Astals Cid

merge

Revision history for this message
Michał Sawicz (saviq) wrote :

Works fine, code looks good, test works!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/launcher/IntelliHideBehavior.qml'
2--- shell/launcher/IntelliHideBehavior.qml 2012-01-18 15:19:04 +0000
3+++ shell/launcher/IntelliHideBehavior.qml 2012-01-23 08:52:24 +0000
4@@ -12,8 +12,10 @@
5 onForcedVisibleChanged:
6 {
7 if (!forcedVisible) {
8- shownBecauseOfMousePosition = true
9- mouseLeaveTimer.restart()
10+ if (!target.containsMouse) {
11+ shownBecauseOfMousePosition = true
12+ mouseLeaveTimer.restart()
13+ }
14 }
15 }
16

Subscribers

People subscribed via source and target branches