unity-2d

Merge lp:~aacid/unity-2d/unity-2d-shell_dash_home_shortcuts_todo_fixme into lp:~unity-2d-team/unity-2d/unity-2d-shell

  1. unity-2d-shell_dash_home_shortcuts_todo_fixme
  2. Merge into unity-2d-shell
Proposed by Albert Astals Cid
Status: Merged
Approved by: Florian Boucault
Approved revision: 986
Merged at revision: 986
Proposed branch: lp:~aacid/unity-2d/unity-2d-shell_dash_home_shortcuts_todo_fixme
Merge into: lp:~unity-2d-team/unity-2d/unity-2d-shell
Diff against target: 15 lines (+3/-2)
1 file modified
shell/dash/HomeShortcuts.qml (+3/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/unity-2d-shell_dash_home_shortcuts_todo_fixme
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+92018@code.launchpad.net

Description of the change

TODO -> FIXME and rework the text

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/dash/HomeShortcuts.qml'
2--- shell/dash/HomeShortcuts.qml 2012-01-30 13:53:59 +0000
3+++ shell/dash/HomeShortcuts.qml 2012-02-08 12:22:20 +0000
4@@ -29,8 +29,9 @@
5 Grid {
6 id: buttons
7
8- // TODO The alignment here is broken in RTL but Gerry says it's going away so we
9- // do not care about it. Don't ask me why this transparent rectangle fixes it
10+ // FIXME Need this invisible Rectangle so that alignment in RTL is not broken and tests pass.
11+ // Gerry says the Home lens is going away so we do not care about a better fix
12+ // Don't ask me why the transparent Rectangle fixes the alignment though
13 Rectangle {
14 anchors.fill: parent
15 opacity: 0

Subscribers

People subscribed via source and target branches