Merge lp:~aacid/unity-2d/intellihide_is_autohide into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michał Sawicz
Approved revision: 947
Merged at revision: 950
Proposed branch: lp:~aacid/unity-2d/intellihide_is_autohide
Merge into: lp:unity-2d
Diff against target: 96 lines (+19/-46)
2 files modified
shell/common/visibilityBehaviors/AutoHideBehavior.qml (+15/-3)
shell/common/visibilityBehaviors/IntelliHideBehavior.qml (+4/-43)
To merge this branch: bzr merge lp:~aacid/unity-2d/intellihide_is_autohide
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Gerry Boland Pending
Review via email: mp+95559@code.launchpad.net

Description of the change

Make IntelliHide inherit from AutoHide and bring fixes up from IntelliHide to AutoHide

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/common/visibilityBehaviors/AutoHideBehavior.qml'
2--- shell/common/visibilityBehaviors/AutoHideBehavior.qml 2012-02-20 14:18:31 +0000
3+++ shell/common/visibilityBehaviors/AutoHideBehavior.qml 2012-03-02 13:50:24 +0000
4@@ -28,9 +28,21 @@
5
6 BaseBehavior {
7 id: autoHide
8+
9 property bool shownRegardlessOfFocus: true
10-
11- shown: target !== undefined && (target.activeFocus || shownRegardlessOfFocus)
12+ property bool autoHideShown: target !== undefined && (target.activeFocus || shownRegardlessOfFocus)
13+
14+ shown: autoHideShown
15+
16+ onForcedVisibleChanged:
17+ {
18+ if (!forcedVisible) {
19+ if (!target.containsMouse && forcedVisibleChangeId != "dash") {
20+ shownRegardlessOfFocus = true
21+ autoHideTimer.restart()
22+ }
23+ }
24+ }
25
26 Timer {
27 id: autoHideTimer
28@@ -48,7 +60,7 @@
29 Connections {
30 target: (autoHide.target !== undefined) ? autoHide.target : null
31 onContainsMouseChanged: {
32- if (target.activeFocus) {
33+ if ((shown || forcedVisible) && target.containsMouse) {
34 shownRegardlessOfFocus = true
35 }
36 }
37
38=== modified file 'shell/common/visibilityBehaviors/IntelliHideBehavior.qml'
39--- shell/common/visibilityBehaviors/IntelliHideBehavior.qml 2012-02-08 16:18:21 +0000
40+++ shell/common/visibilityBehaviors/IntelliHideBehavior.qml 2012-03-02 13:50:24 +0000
41@@ -29,51 +29,12 @@
42 // - containsMouse: Defines if the mouse is inside the target
43 // - outerEdgeContainsMouse: Defines if the mouse is in the edge of the target
44
45-BaseBehavior {
46+AutoHideBehavior {
47 id: intellihide
48
49- property bool shownBecauseOfMousePosition: false
50-
51- shown: target !== undefined && (target.activeFocus || shownBecauseOfMousePosition || !windows.intersects)
52-
53- onForcedVisibleChanged:
54- {
55- if (!forcedVisible) {
56- if (!target.containsMouse && forcedVisibleChangeId != "dash") {
57- shownBecauseOfMousePosition = true
58- mouseLeaveTimer.restart()
59- }
60- }
61- }
62-
63- Timer {
64- id: edgeHitTimer
65- interval: 500
66- onTriggered: shownBecauseOfMousePosition = true
67- }
68-
69- Timer {
70- id: mouseLeaveTimer
71- interval: 1000
72- onTriggered: shownBecauseOfMousePosition = false
73- }
74-
75- Connections {
76- target: (intellihide.target !== undefined) ? intellihide.target : null
77- onOuterEdgeContainsMouseChanged: edgeHitTimer.running = target.outerEdgeContainsMouse
78- ignoreUnknownSignals: true
79- }
80-
81- Connections {
82- target: (intellihide.target !== undefined) ? intellihide.target : null
83- onContainsMouseChanged: {
84- if ((shown || forcedVisible) && target.containsMouse) {
85- shownBecauseOfMousePosition = true
86- }
87- mouseLeaveTimer.running = !target.containsMouse
88- }
89- ignoreUnknownSignals: true
90- }
91+ property bool intelliHideShown: autoHideShown || (target !== undefined && !windows.intersects)
92+
93+ shown: intelliHideShown
94
95 WindowsIntersectMonitor {
96 id: windows

Subscribers

People subscribed via source and target branches