Code review comment for lp:~aacid/ubuntu-ui-toolkit/nonsquareicons

Albert Astals Cid (aacid) wrote :

Without the changes in the cpp code these are the tests that fail

tst_iconprovider: FAIL! : tst_IconProvider::test_loadIcon(battery2) Compared values are not the same
   tst_iconprovider: Actual (p.size()) : QSize(24x16)
   tst_iconprovider: Expected (resultSize): QSize(16x10)
   tst_iconprovider: Loc: [tst_iconprovider.cpp(69)]
i.e. asking for a 16x-1 icon returns a 24x16 icon

tst_iconprovider: FAIL! : tst_IconProvider::test_loadIcon(battery4) Compared values are not the same
   tst_iconprovider: Actual (p.size()) : QSize(24x16)
   tst_iconprovider: Expected (resultSize): QSize(16x10)
   tst_iconprovider: Loc: [tst_iconprovider.cpp(69)]
i.e. asking for a 16x0 icon returns a 24x16 icon

tst_iconprovider: FAIL! : tst_IconProvider::test_loadIcon(battery5) Compared values are not the same
   tst_iconprovider: Actual (p.size()) : QSize(37x24)
   tst_iconprovider: Expected (resultSize): QSize(24x16)
   tst_iconprovider: Loc: [tst_iconprovider.cpp(69)]
i.e. asking for a 24x16 icon returns a 37x24 icon

tst_iconprovider: FAIL! : tst_IconProvider::test_loadIcon(battery7) Compared values are not the same
   tst_iconprovider: Actual (p.size()) : QSize(57x37)
   tst_iconprovider: Expected (resultSize): QSize(37x24)
   tst_iconprovider: Loc: [tst_iconprovider.cpp(69)]
i.e. asking for a 37x24 icon returns a 57x27 icon

« Back to merge proposal