Merge lp:~aacid/ubuntu-ui-toolkit/initialize_variable into lp:ubuntu-ui-toolkit/staging

[Albert Astals Cid]

Fix conditional jump or move depends on uninitialised value(s)

    Valgrind says
    ==11560== Conditional jump or move depends on uninitialised value(s)
    ==11560== at 0x2D64BC9F: getVerticalPositioningMode (ucslotslayout.cpp:75)
    ==11560== by 0x2D64BC9F: UCSlotsLayoutPrivate::updateTopBottomPaddingIfNeeded() (ucslotslayout.cpp:82)
    ==11560== by 0x2D64CEA9: UCSlotsLayoutPrivate::_q_updateGuValues() (ucslotslayout.cpp:211)
    ==11560== by 0x2D64CEFA: UCSlotsLayoutPrivate::init() (ucslotslayout.cpp:50)
    ==11560== by 0x2D63DE88: UCListItemLayout::UCListItemLayout(QQuickItem*) (uclistitemlayout.cpp:353)
    ==11560== by 0x2D60037F: QQmlElement (qqmlprivate.h:99)
    ==11560== by 0x2D60037F: void QQmlPrivate::createInto<UCListItemLayout>(void*) (qqmlprivate.h:108)
    ==11560== by 0x6BD1C98: QQmlType::create() const (qqmlmetatype.cpp:746)
    ==11560== by 0x6C33F3B: QQmlObjectCreator::createInstance(int, QObject*, bool) (qqmlobjectcreator.cpp:1080)
    ==11560== by 0x6C3645E: QQmlObjectCreator::setPropertyBinding(QQmlPropertyData const*, QV4::CompiledData::Binding const*) (qqmlobjectcreator.cpp:776)
    ==11560== by 0x6C366C7: QQmlObjectCreator::setupBindings(QBitArray const&) (qqmlobjectcreator.cpp:728)
    ==11560== by 0x6C33655: QQmlObjectCreator::populateInstance(int, QObject*, QObject*, QQmlPropertyData const*, QBitArray const&) (qqmlobjectcreator.cpp:1355)
    ==11560== by 0x6C34236: QQmlObjectCreator::createInstance(int, QObject*, bool) (qqmlobjectcreator.cpp:1202)
    ==11560== by 0x6C34A55: QQmlObjectCreator::create(int, QObject*, QQmlInstantiationInterrupt*) (qqmlobjectcreator.cpp:204)

[Andrea Bernabei (faenil)]

Thanks, good catch!

Which makes me think, we should definitely be using -Wuninitialized and -Werror=unintialized

What do you think?

[Andrea Bernabei (faenil)]

great, thanks!

review: Approve

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1392/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7580/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1392/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1427/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7581/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1427/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1642/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7582/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1642/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/206/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7583/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/206/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/887/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1642
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1427
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1392
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/206
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7584/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7582
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7581
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7580
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7583

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/887/rebuild

review: Approve (continuous-integration)

[Andrea Bernabei (faenil)]

after checking -Wuninitialized doc, it seems it does not catch uninitialized members (in fact, it would be really trick to check that). So that wouldn't help

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1393/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7585/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1393/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1428/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7586/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1428/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/207/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7587/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/207/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2167
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1643/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7588/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1643/rebuild

review: Approve (continuous-integration)

=== modified file 'src/UbuntuToolkit/ucslotslayout.cpp'
--- src/UbuntuToolkit/ucslotslayout.cpp	2016-10-07 14:33:47 +0000
+++ src/UbuntuToolkit/ucslotslayout.cpp	2017-02-01 16:11:23 +0000
@@ -32,6 +32,7 @@
     : QQuickItemPrivate()
     , mainSlot(Q_NULLPTR)
     , m_parentItem(Q_NULLPTR)
+    , mainSlotHeight(0)
     , maxSlotsHeight(0)
     , _q_cachedHeight(-1)
     , maxNumberOfLeadingSlots(1)