Merge lp:~aacid/ubuntu-ui-toolkit/ima_do_not_filter_disabled into lp:ubuntu-ui-toolkit

Proposed by Albert Astals Cid
Status: Merged
Approved by: Florian Boucault
Approved revision: 831
Merged at revision: 837
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/ima_do_not_filter_disabled
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 13 lines (+3/-0)
1 file modified
modules/Ubuntu/Components/plugin/inversemouseareatype.cpp (+3/-0)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/ima_do_not_filter_disabled
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+194830@code.launchpad.net

Commit message

InverseMouseArea: Do not filter events if disabled

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Nice! Thanks for that ;)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:831
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/1211/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/691
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/677
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-ci/159
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/159
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/159/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/625
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/691
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/691/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/677
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/677/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/3091
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3307
    SUCCESS: http://s-jenkins:8080/job/touch-flash-device/1402
    SUCCESS: http://s-jenkins:8080/job/touch-flash-device/1401

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/1211/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/plugin/inversemouseareatype.cpp'
2--- modules/Ubuntu/Components/plugin/inversemouseareatype.cpp 2013-10-29 17:16:45 +0000
3+++ modules/Ubuntu/Components/plugin/inversemouseareatype.cpp 2013-11-12 11:20:41 +0000
4@@ -319,6 +319,9 @@
5
6 bool InverseMouseAreaType::eventFilter(QObject *object, QEvent *event)
7 {
8+ if (!isEnabled())
9+ return false;
10+
11 if (object != this)
12 {
13 bool captured = true;

Subscribers

People subscribed via source and target branches

to status/vote changes: