Ubuntu UI Toolkit

Merge lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak into lp:ubuntu-ui-toolkit/staging

  1. fix_ucstylehints_leak
  2. Merge into staging
Proposed by Albert Astals Cid on 2017-02-28
Status: Merged
Approved by: Zsombor Egri on 2017-02-28
Approved revision: 2182
Merged at revision: 2182
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 10 lines (+1/-0)
1 file modified
src/UbuntuToolkit/ucstylehints.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve on 2017-02-28
Zsombor Egri (community) 2017-02-28 Approve on 2017-02-28
Review via email: mp+318478@code.launchpad.net

Commit Message

Fix memory leak in UCStyleHints

Description of the Change

Without this i get warnings in valgrind about leaking PropertyChange's

To post a comment you must log in.
Zsombor Egri (zsombi) wrote :

Stupid mistake, thanks for fixing it!!!

review: Approve
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/UbuntuToolkit/ucstylehints.cpp'
2--- src/UbuntuToolkit/ucstylehints.cpp 2016-09-12 09:03:50 +0000
3+++ src/UbuntuToolkit/ucstylehints.cpp 2017-02-28 13:36:12 +0000
4@@ -273,6 +273,7 @@
5
6 newBinding->setTarget(change->property());
7 PropertyChange::setBinding(change, newBinding);
8+ m_propertyBackup << change;
9 }
10 }
11

Subscribers

People subscribed via source and target branches