Ubuntu UI Toolkit

Merge lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak into lp:ubuntu-ui-toolkit/staging

  1. fix_ucstylehints_leak
  2. Merge into staging
Proposed by Albert Astals Cid
Status: Merged
Approved by: Zsombor Egri
Approved revision: 2182
Merged at revision: 2182
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 10 lines (+1/-0)
1 file modified
src/UbuntuToolkit/ucstylehints.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+318478@code.launchpad.net

Commit message

Fix memory leak in UCStyleHints

Description of the change

Without this i get warnings in valgrind about leaking PropertyChange's

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Stupid mistake, thanks for fixing it!!!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2182
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1476/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7801/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1476/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2182
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1691/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7802/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1691/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2182
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/916/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1691
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1476
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7803/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7802
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7801

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/916/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2182
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1477/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7804/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1477/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2182
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1692/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7805/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1692/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/UbuntuToolkit/ucstylehints.cpp'
2--- src/UbuntuToolkit/ucstylehints.cpp 2016-09-12 09:03:50 +0000
3+++ src/UbuntuToolkit/ucstylehints.cpp 2017-02-28 13:36:12 +0000
4@@ -273,6 +273,7 @@
5
6 newBinding->setTarget(change->property());
7 PropertyChange::setBinding(change, newBinding);
8+ m_propertyBackup << change;
9 }
10 }
11

Subscribers

People subscribed via source and target branches