Merge lp:~aacid/ubuntu-ui-toolkit/fix-pageheadstyle-width into lp:ubuntu-ui-toolkit/staging

Proposed by Albert Astals Cid
Status: Merged
Merge reported by: Tim Peeters
Merged at revision: not available
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/fix-pageheadstyle-width
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/fix-pageheadstyle-width
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tim Peeters Approve
Review via email: mp+238115@code.launchpad.net

Commit message

Don't add up margins for actionsContainer if it's not there

Description of the change

Don't add up margins for actionsContainer if it's not there

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

Thanks, looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

argh.. autolanding is really not cooperating. But I don't know why it fails, still seems random. See https://docs.google.com/a/canonical.com/document/d/1ZNuwhyf4n98DZrB0Lv4sE81PMzuPnNSI8UG7pv6nPPI/edit#

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml'
2--- modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2014-10-07 10:58:42 +0000
3+++ modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2014-10-13 09:48:45 +0000
4@@ -440,7 +440,7 @@
5 anchors {
6 top: parent.top
7 right: rightAnchor.left
8- rightMargin: units.gu(1)
9+ rightMargin: actionsContainer.width > 0 ? units.gu(1) : 0
10 }
11 width: childrenRect.width
12 height: headerStyle.contentHeight

Subscribers

People subscribed via source and target branches