Merge lp:~aacid/qtubuntu/remove_unused_signal into lp:qtubuntu

Proposed by Albert Astals Cid on 2017-03-27
Status: Merged
Approved by: Lukáš Tinkl on 2017-03-27
Approved revision: 385
Merged at revision: 387
Proposed branch: lp:~aacid/qtubuntu/remove_unused_signal
Merge into: lp:qtubuntu
Diff against target: 127 lines (+0/-15)
2 files modified
src/ubuntuappmenu/gmenumodelplatformmenu.cpp (+0/-13)
src/ubuntuappmenu/gmenumodelplatformmenu.h (+0/-2)
To merge this branch: bzr merge lp:~aacid/qtubuntu/remove_unused_signal
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) 2017-03-27 Approve on 2017-03-27
Unity8 CI Bot continuous-integration Approve on 2017-03-27
Review via email: mp+321041@code.launchpad.net

Commit message

Remove signal noone uses

To post a comment you must log in.
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:385
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/215/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4702
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4730
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4553/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4553/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4553/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4553/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4553/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4553
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4553/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/215/rebuild

review: Approve (continuous-integration)
Lukáš Tinkl (lukas-kde) wrote :

LGTM, makes sense, CI passing too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntuappmenu/gmenumodelplatformmenu.cpp'
2--- src/ubuntuappmenu/gmenumodelplatformmenu.cpp 2017-03-13 14:16:52 +0000
3+++ src/ubuntuappmenu/gmenumodelplatformmenu.cpp 2017-03-27 08:22:32 +0000
4@@ -241,7 +241,6 @@
5 MENU_DEBUG_MSG << "(text=" << text << ")";
6 if (m_text != text) {
7 m_text = text;
8- Q_EMIT propertyChanged();
9 }
10 }
11
12@@ -251,7 +250,6 @@
13
14 if (!icon.isNull() || (!m_icon.isNull() && icon.isNull())) {
15 m_icon = icon;
16- Q_EMIT propertyChanged();
17 }
18 }
19
20@@ -262,7 +260,6 @@
21 if (m_enabled != enabled) {
22 m_enabled = enabled;
23 Q_EMIT enabledChanged(enabled);
24- Q_EMIT propertyChanged();
25 }
26 }
27
28@@ -272,7 +269,6 @@
29
30 if (m_visible != isVisible) {
31 m_visible = isVisible;
32- Q_EMIT propertyChanged();
33 }
34 }
35
36@@ -404,7 +400,6 @@
37 ITEM_DEBUG_MSG << "(text=" << text << ")";
38 if (m_text != text) {
39 m_text = text;
40- Q_EMIT propertyChanged();
41 }
42 }
43
44@@ -414,7 +409,6 @@
45
46 if (!icon.isNull() || (!m_icon.isNull() && icon.isNull())) {
47 m_icon = icon;
48- Q_EMIT propertyChanged();
49 }
50 }
51
52@@ -423,7 +417,6 @@
53 ITEM_DEBUG_MSG << "(visible=" << isVisible << ")";
54 if (m_visible != isVisible) {
55 m_visible = isVisible;
56- Q_EMIT propertyChanged();
57 }
58 }
59
60@@ -432,7 +425,6 @@
61 ITEM_DEBUG_MSG << "(separator=" << isSeparator << ")";
62 if (m_separator != isSeparator) {
63 m_separator = isSeparator;
64- Q_EMIT propertyChanged();
65 }
66 }
67
68@@ -453,7 +445,6 @@
69 ITEM_DEBUG_MSG << "(checkable=" << checkable << ")";
70 if (m_checkable != checkable) {
71 m_checkable = checkable;
72- Q_EMIT propertyChanged();
73 }
74 }
75
76@@ -463,7 +454,6 @@
77 if (m_checked != isChecked) {
78 m_checked = isChecked;
79 Q_EMIT checkedChanged(isChecked);
80- Q_EMIT propertyChanged();
81 }
82 }
83
84@@ -472,7 +462,6 @@
85 ITEM_DEBUG_MSG << "(shortcut=" << shortcut << ")";
86 if (m_shortcut != shortcut) {
87 m_shortcut = shortcut;
88- Q_EMIT propertyChanged();
89 }
90 }
91
92@@ -482,7 +471,6 @@
93 if (m_enabled != enabled) {
94 m_enabled = enabled;
95 Q_EMIT enabledChanged(enabled);
96- Q_EMIT propertyChanged();
97 }
98 }
99
100@@ -497,7 +485,6 @@
101 ITEM_DEBUG_MSG << "(menu=" << menu << ")";
102 if (m_menu != menu) {
103 m_menu = menu;
104- Q_EMIT propertyChanged();
105
106 if (menu) {
107 connect(menu, &QObject::destroyed,
108
109=== modified file 'src/ubuntuappmenu/gmenumodelplatformmenu.h'
110--- src/ubuntuappmenu/gmenumodelplatformmenu.h 2017-03-20 17:30:48 +0000
111+++ src/ubuntuappmenu/gmenumodelplatformmenu.h 2017-03-27 08:22:32 +0000
112@@ -112,7 +112,6 @@
113 void menuItemRemoved(QPlatformMenuItem *menuItem);
114 void structureChanged();
115 void enabledChanged(bool);
116- void propertyChanged();
117
118 private:
119 MENU_PROPERTY(UbuntuPlatformMenu, visible, bool, true)
120@@ -160,7 +159,6 @@
121 Q_SIGNALS:
122 void checkedChanged(bool);
123 void enabledChanged(bool);
124- void propertyChanged();
125
126 private:
127 MENU_PROPERTY(UbuntuPlatformMenuItem, separator, bool, false)

Subscribers

People subscribed via source and target branches