Merge lp:~aacid/qtubuntu/initialize_tag into lp:qtubuntu

[Albert Astals Cid]

Initialize m_tag

It's most probably not needed but it's proper to do.

On what to initialize half of the QPA do 0 and half do this, i went for this

In https://codereview.qt-project.org/#/c/187283/ i'm proposing to remove tag from the pure virtuals the platform has to implement since it means nothing, but meanwhile let's initialize the field.

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:372
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/193/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4276
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4304
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4138/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4138/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4138/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4138/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4138/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4138
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4138/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/193/rebuild

review: Approve (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

Yup, makes sense (I see the change got ~accepted upstream as well, good).

review: Approve

=== modified file 'src/ubuntuappmenu/gmenumodelplatformmenu.cpp'
--- src/ubuntuappmenu/gmenumodelplatformmenu.cpp	2017-02-13 16:10:06 +0000
+++ src/ubuntuappmenu/gmenumodelplatformmenu.cpp	2017-03-02 09:56:39 +0000
@@ -166,7 +166,8 @@
 //////////////////////////////////////////////////////////////
 
 UbuntuPlatformMenu::UbuntuPlatformMenu()
-    : m_parentWindow(nullptr)
+    : m_tag(reinterpret_cast<quintptr>(this))
+    , m_parentWindow(nullptr)
     , m_exporter(nullptr)
     , m_registrar(nullptr)
 {
@@ -380,6 +381,7 @@
 
 UbuntuPlatformMenuItem::UbuntuPlatformMenuItem()
     : m_menu(nullptr)
+    , m_tag(reinterpret_cast<quintptr>(this))
 {
     ITEM_DEBUG_MSG << "()";
 }