lp:~aacid/qtubuntu/fix_crash_starting_konsole

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:qtubuntu at revision 369

Nick Dedekind (community): Approve on 2017-02-13

Unity8 CI Bot: Approve (continuous-integration) on 2017-02-13

Diff: 14 lines (+5/-0)

1 file modified

src/ubuntuappmenu/gmenumodelplatformmenu.cpp (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

379. By Albert Astals Cid on 2017-02-13

Fix crash when starting konsole

valgrind says
==31368== Invalid read of size 8
==31368== at 0x2801D880: QList<QPlatformMenuItem*>::QList(QList<QPlatformMenuItem*> const&) (qlist.h:803)
==31368== by 0x2801A5BC: UbuntuPlatformMenu::menuItems() const (gmenumodelplatformmenu.cpp:361)
==31368== by 0x28011257: UbuntuGMenuModelExporter::addSubmenuItems(UbuntuPlatformMenu*, _GMenu*) (gmenumodelexporter.cpp:228)
==31368== by 0x28011537: UbuntuGMenuModelExporter::createSubmenu(QPlatformMenu*, UbuntuPlatformMenuItem*) (gmenumodelexporter.cpp:217)
==31368== by 0x28011164: UbuntuGMenuModelExporter::processItemForGMenu(QPlatformMenuItem*, _GMenu*) (gmenumodelexporter.cpp:296)
==31368== by 0x28011350: UbuntuGMenuModelExporter::addSubmenuItems(UbuntuPlatformMenu*, _GMenu*) (gmenumodelexporter.cpp:244)
==31368== by 0x28011537: UbuntuGMenuModelExporter::createSubmenu(QPlatformMenu*, UbuntuPlatformMenuItem*) (gmenumodelexporter.cpp:217)
==31368== by 0x28011BB6: operator() (gmenumodelexporter.cpp:69)
==31368== by 0x28011BB6: call (qobjectdefs_impl.h:135)
==31368== by 0x28011BB6: call<QtPrivate::List<>, void> (qobjectdefs_impl.h:192)
==31368== by 0x28011BB6: QtPrivate::QFunctorSlotObject<UbuntuMenuBarExporter::UbuntuMenuBarExporter(UbuntuPlatformMenuBar*)::{lambda()#2}, 0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (qobject_impl.h:169)
==31368== by 0x8BE581D: call (qobject_impl.h:101)
==31368== by 0x8BE581D: QMetaObject::activate(QObject*, int, int, void**) (qobject.cpp:3723)
==31368== by 0x8BF1E37: QTimer::timerEvent(QTimerEvent*) (qtimer.cpp:254)
==31368== by 0x8BE6312: QObject::event(QEvent*) (qobject.cpp:1285)
==31368== by 0x786A35B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (qapplication.cpp:3799)
==31368== Address 0x26408048 is 56 bytes inside a block of size 88 free'd
==31368== at 0x4C2E25B: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31368== by 0x79E11C1: QMenuPrivate::~QMenuPrivate() (qmenu_p.h:297)
==31368== by 0x79E1248: QMenuPrivate::~QMenuPrivate() (qmenu_p.h:301)
==31368== by 0x8BED0A6: cleanup (qscopedpointer.h:60)
==31368== by 0x8BED0A6: ~QScopedPointer (qscopedpointer.h:107)
==31368== by 0x8BED0A6: QObject::~QObject() (qobject.cpp:900)
==31368== by 0x78AD452: QWidget::~QWidget() (qwidget.cpp:1555)
==31368== by 0x79DA918: QMenu::~QMenu() (qmenu.cpp:1518)
==31368== by 0x8BE638F: QObject::event(QEvent*) (qobject.cpp:1254)
==31368== by 0x78B1C6A: QWidget::event(QEvent*) (qwidget.cpp:9225)
==31368== by 0x79E0342: QMenu::event(QEvent*) (qmenu.cpp:2799)
==31368== by 0x786A35B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (qapplication.cpp:3799)
==31368== by 0x7871B10: QApplication::notify(QObject*, QEvent*) (qapplication.cpp:3556)
==31368== by 0x8BB989F: QCoreApplication::notifyInternal2(QObject*, QEvent*) (qcoreapplication.cpp:988)
==31368== Block was alloc'd at
==31368== at 0x4C2D19F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31368== by 0x2800F6EB: UbuntuAppMenuTheme::createPlatformMenu() const (theme.cpp:69)
==31368== by 0x79D512D: QMenuPrivate::init() (qmenu.cpp:156)
==31368== by 0x6DE8354: KActionMenu::KActionMenu(QIcon const&, QString const&, QObject*) (in /usr/lib/x86_64-linux-gnu/libKF5WidgetsAddons.so.5.28.0)
==31368== by 0x4E56833: ??? (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x4E591F2: ??? (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x4E4D90F: ??? (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x4E4E373: ??? (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x4E528F1: ??? (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x4E60D24: kdemain (in /usr/lib/x86_64-linux-gnu/libkdeinit5_konsole.so)
==31368== by 0x50A03F0: (below main) (libc-start.c:291)

378. By Arthur Mello on 2017-02-07

Make sure pixel format is applied in makeSurfaceSpec

377. By Arthur Mello on 2017-02-07

Rename mirWindowStateToWindowState to mirWindowStateToQt

376. By Arthur Mello on 2017-02-07

Replace deprecated mir_debug_surface_coords_to_screen

375. By Arthur Mello on 2017-02-07

Update the copyright header of all modified files to 2017

374. By Arthur Mello on 2017-02-07

Merge with lp:~gerboland/qtubuntu/upstream-closer

373. By Arthur Mello on 2017-02-07

Remove deprecated mir_event_type_input_configuration

372. By Arthur Mello on 2017-02-07

Replace more deprecated enum entries

371. By Arthur Mello on 2017-02-07

Replace deprecated enum entries mir_event_type_close_surface/mir_event_type_surface_output/mir_event_type_surface_placement

370. By Arthur Mello on 2017-02-07

Change mir_event_type_surface to user mir_event_type_window