Merge lp:~aacid/qtubuntu/const_ref into lp:qtubuntu

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 192
Merged at revision: 192
Proposed branch: lp:~aacid/qtubuntu/const_ref
Merge into: lp:qtubuntu
Diff against target: 25 lines (+2/-2)
2 files modified
src/modules/application/input_filter_area.cc (+1/-1)
src/modules/application/input_filter_area.h (+1/-1)
To merge this branch: bzr merge lp:~aacid/qtubuntu/const_ref
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+194126@code.launchpad.net

Commit message

Pass QRectF as const reference instead of copying it

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/modules/application/input_filter_area.cc'
2--- src/modules/application/input_filter_area.cc 2013-02-14 16:31:33 +0000
3+++ src/modules/application/input_filter_area.cc 2013-11-06 12:22:44 +0000
4@@ -135,7 +135,7 @@
5 disconnectFromAscendantsChanges();
6 }
7
8-QRect InputFilterArea::relativeToAbsoluteGeometry(QRectF relativeGeometry) {
9+QRect InputFilterArea::relativeToAbsoluteGeometry(const QRectF & relativeGeometry) {
10 if (parentItem()) {
11 return parentItem()->mapRectToScene(relativeGeometry).toRect();
12 } else {
13
14=== modified file 'src/modules/application/input_filter_area.h'
15--- src/modules/application/input_filter_area.h 2013-02-14 16:31:33 +0000
16+++ src/modules/application/input_filter_area.h 2013-11-06 12:22:44 +0000
17@@ -47,7 +47,7 @@
18 void setInputTrap(const QRect & geometry);
19 void enableInputTrap();
20 void disableInputTrap();
21- QRect relativeToAbsoluteGeometry(QRectF relativeGeometry);
22+ QRect relativeToAbsoluteGeometry(const QRectF &relativeGeometry);
23
24 bool blockInput_;
25 unsigned int trapHandle_;

Subscribers

People subscribed via source and target branches