Merge lp:~aacid/qtmir/fix_screens_model_test_leak into lp:qtmir

Proposed by Albert Astals Cid
Status: Superseded
Proposed branch: lp:~aacid/qtmir/fix_screens_model_test_leak
Merge into: lp:qtmir
Diff against target: 29 lines (+8/-0)
2 files modified
CMakeLists.txt (+7/-0)
tests/mirserver/ScreensModel/screensmodel_test.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/qtmir/fix_screens_model_test_leak
Reviewer Review Type Date Requested Status
Mir development team Pending
Review via email: mp+295736@code.launchpad.net

This proposal has been superseded by a proposal from 2016-05-25.

Commit message

Fix leak in ScreensModelTest

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
Prereq (well not really but makes for easier testing)

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-05-18 11:15:56 +0000
3+++ CMakeLists.txt 2016-05-25 15:50:19 +0000
4@@ -13,6 +13,13 @@
5 # Find includes in corresponding build directories
6 set(CMAKE_INCLUDE_CURRENT_DIR ON)
7
8+find_package (ECM 1.7.0 QUIET NO_MODULE)
9+if (ECM_FOUND)
10+ # Provides us with -DECM_ENABLE_SANITIZERS='X'
11+ # Where X can be address, thread, memory, leak, undefined
12+ include("${ECM_MODULE_DIR}/ECMEnableSanitizers.cmake")
13+endif()
14+
15 # add custom cmake modules
16 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules)
17
18
19=== modified file 'tests/mirserver/ScreensModel/screensmodel_test.cpp'
20--- tests/mirserver/ScreensModel/screensmodel_test.cpp 2016-04-29 15:41:00 +0000
21+++ tests/mirserver/ScreensModel/screensmodel_test.cpp 2016-05-25 15:50:19 +0000
22@@ -64,6 +64,7 @@
23 void ScreensModelTest::TearDown()
24 {
25 delete screensModel;
26+ delete app;
27 }
28
29 TEST_F(ScreensModelTest, SingleScreenFound)

Subscribers

People subscribed via source and target branches