QtMir

Merge lp:~aacid/qtmir/fix_memory_leak_application_test into lp:qtmir

  1. fix_memory_leak_application_test
  2. Merge into trunk
Proposed by Albert Astals Cid on 2016-06-20
Status: Merged
Approved by: Daniel d'Andrada on 2016-06-23
Approved revision: 504
Merged at revision: 535
Proposed branch: lp:~aacid/qtmir/fix_memory_leak_application_test
Merge into: lp:qtmir
Diff against target: 12 lines (+2/-0)
1 file modified
tests/modules/Application/application_test.cpp (+2/-0)
To merge this branch: bzr merge lp:~aacid/qtmir/fix_memory_leak_application_test
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) 2016-06-20 Approve on 2016-06-23
Unity8 CI Bot continuous-integration Approve on 2016-06-20
Review via email: mp+297876@code.launchpad.net

Commit Message

Fix memory leak in application_test

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:504
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/284/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2058
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2086
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1997
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1997
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1997
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1988/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1988
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1988/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/284/rebuild

review: Approve (continuous-integration)
Daniel d'Andrada (dandrader) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/modules/Application/application_test.cpp'
2--- tests/modules/Application/application_test.cpp 2016-06-03 11:08:30 +0000
3+++ tests/modules/Application/application_test.cpp 2016-06-20 08:14:09 +0000
4@@ -620,6 +620,8 @@
5 EXPECT_EQ(application->surfaceCount(), 2);
6 EXPECT_EQ(surfaceCountChangedSpy.count(), 2);
7
8+ delete surface;
9+ delete surface2;
10 }
11
12 /*

Subscribers

People subscribed via source and target branches