lp:~aacid/qtmir/fixAuthorizeDeadlock

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:qtmir at revision 628

Gerry Boland (community): Approve on 2017-03-24

Unity8 CI Bot (community): Approve (continuous-integration) on 2017-03-24

Diff: 607 lines (+133/-75)

6 files modified

src/modules/Unity/Application/application.cpp (+0/-27)
src/modules/Unity/Application/application.h (+0/-4)
src/modules/Unity/Application/application_manager.cpp (+120/-36)
src/modules/Unity/Application/application_manager.h (+12/-0)
src/modules/Unity/Application/taskcontroller.cpp (+1/-6)
src/modules/Unity/Application/taskcontroller.h (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1525285: Unity8 deadlock when trying to screenshot without a current gst registry

High

Fix Released

Link a bug report

Related blueprints

623. By Albert Astals Cid on 2017-03-24

Merge

622. By Albert Astals Cid on 2017-03-22

spacing

621. By Albert Astals Cid on 2017-03-22

Move pid storing to ApplicationManager

Instead of application since the only thing that needs it is the ApplicationManager
this way instead of queuing its setting we can just set it directly

Fixes crash we had on a test

620. By Albert Astals Cid on 2017-03-22

Run ApplicationManager::authorizeSession in the calling thread

Instead of using a BlockingQueuedConnection

This fixes the deadlock we have when we are creating a player that uses gstreamer and
gstreamer needs to update its registry (which blocks waiting for an external process to finish)
and that external process tries to connect to mir.

Adds a QMutex in ApplicationManager that protects the public functions and slots

The mutex needs to be recursive since for example beginInsertRows call in add() will call rowCount()

The setPid/addApp functions are still run through a queued signal so that the model/QObjects are still all handled in the main thread.

findApplicationMutexHeld is not really necessary since the mutex is recursive but thought it's better to leave the recursive use for when it's really needed

619. By Albert Astals Cid on 2017-03-22

Remove empty property and move invokable

They are not part of the interface and not used by unity8 either

618. By Gerry Boland on 2017-03-20

Fix FTBFS against miral 1.3.1

Approved by: Daniel d'Andrada, Unity8 CI Bot, Alan Griffiths

617. By CI Train Bot Account on 2017-03-07

Releasing 0.5.1+17.04.20170307-0ubuntu1

616. By Daniel d'Andrada on 2017-03-07

DBusFocusInfo: fix crash when trying to access a null session from an application

An application that has just been started might not have a session yet. (LP: #1670710)

Approved by: Gerry Boland, Unity8 CI Bot

615. By Albert Astals Cid on 2017-03-07

Fix clang build

    /home/tsdgeos/phablet/qtmir/qtmir/src/platforms/mirserver/mirserverhooks.cpp:40:11: error: member 'PromptSessionListener' found in multiple base classes of different types
        using PromptSessionListener::PromptSessionListener;
              ^
    /home/tsdgeos/phablet/qtmir/qtmir/src/platforms/mirserver/promptsessionlistener.h:28:7: note: member found by ambiguous name lookup
    class PromptSessionListener : public QObject
          ^
    /usr/include/mirserver/mir/scene/prompt_session_listener.h:31:7: note: member found by ambiguous name lookup
    class PromptSessionListener
          ^
    1 error generated.

Approved by: Alan Griffiths, Gerry Boland, Unity8 CI Bot

614. By Daniel d'Andrada on 2017-03-07

Reduce default log verbosity

Debug messages won't be logged by default. Only from Informational level and up.
Most debug messages were transformed into informational, but some verbose ones were left as debug (such as window resize and reposition) (LP: #1664151)

Approved by: Gerry Boland, Unity8 CI Bot