QtMir

Merge lp:~aacid/qtmir/fast_string_concatenation into lp:qtmir

  1. fast_string_concatenation
  2. Merge into trunk
Proposed by Albert Astals Cid on 2015-09-30
Status: Merged
Approved by: Gerry Boland on 2015-10-05
Approved revision: 382
Merged at revision: 412
Proposed branch: lp:~aacid/qtmir/fast_string_concatenation
Merge into: lp:qtmir
Diff against target: 13 lines (+3/-0)
1 file modified
CMakeLists.txt (+3/-0)
To merge this branch: bzr merge lp:~aacid/qtmir/fast_string_concatenation
Reviewer Review Type Date Requested Status
Gerry Boland 2015-09-30 Approve on 2015-10-05
PS Jenkins bot continuous-integration Approve on 2015-10-01
Review via email: mp+272938@code.launchpad.net

Commit Message

Enable Efficient String Construction by default

See http://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/qtmir-ci/464/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/160/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/160
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/160/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/42
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/197
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/197
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/197/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/42

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/464/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/qtmir-ci/468/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/164/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/164
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/164/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/201
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/201
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/201/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/468/rebuild

review: Needs Fixing (continuous-integration)
Gerry Boland (gerboland) wrote :

Does this actually *do* anything for us? We do very little string building in qtmir.

It doesn't hurt either

review: Needs Information
Albert Astals Cid (aacid) wrote :

You're right there's not many, a few in application.cpp but it won't hurt and it's for free :D

PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/qtmir-ci/469/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/165
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/165/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/202
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/202
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/202/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/47

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/469/rebuild

review: Approve (continuous-integration)
Gerry Boland (gerboland) wrote :

It's free. I'll take it so.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-09-17 20:17:17 +0000
3+++ CMakeLists.txt 2015-09-30 15:55:55 +0000
4@@ -81,6 +81,9 @@
5
6 add_definitions(-DMIR_REQUIRE_DEPRECATED_EVENT_OPT_IN=1)
7
8+# Use the fast string builder
9+add_definitions(-DQT_USE_QSTRINGBUILDER)
10+
11 include_directories( ${APPLICATION_API_INCLUDE_DIRS} )
12
13 # We expect this to be set via debian/rules for GLES builds

Subscribers

People subscribed via source and target branches