Merge lp:~aacid/qtmir/build_qt57 into lp:qtmir

Proposed by Albert Astals Cid on 2016-11-18
Status: Merged
Approved by: Gerry Boland on 2016-11-18
Approved revision: 570
Merged at revision: 573
Proposed branch: lp:~aacid/qtmir/build_qt57
Merge into: lp:qtmir
Diff against target: 73 lines (+21/-0)
4 files modified
src/platforms/mirserver/miropenglcontext.cpp (+7/-0)
src/platforms/mirserver/miropenglcontext.h (+4/-0)
tests/mirserver/Screen/screen_test.cpp (+8/-0)
tests/mirserver/ScreensModel/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp:~aacid/qtmir/build_qt57
Reviewer Review Type Date Requested Status
Gerry Boland 2016-11-18 Approve on 2016-11-18
Unity8 CI Bot continuous-integration Approve on 2016-11-18
Review via email: mp+311265@code.launchpad.net

Commit Message

Build with Qt 5.7

Description of the Change

Build with Qt 5.7

To post a comment you must log in.
Gerry Boland (gerboland) wrote :

LGTM

review: Approve
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:570
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/409/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3315
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3343
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3195/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3195
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3195/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/409/rebuild

review: Approve (continuous-integration)
lp:~aacid/qtmir/build_qt57 updated on 2016-11-18
571. By Albert Astals Cid on 2016-11-18

Use the generic orientation sensor for the test

Gerry Boland (gerboland) :
review: Approve
lp:~aacid/qtmir/build_qt57 updated on 2016-11-18
572. By Albert Astals Cid on 2016-11-18

sp

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platforms/mirserver/miropenglcontext.cpp'
2--- src/platforms/mirserver/miropenglcontext.cpp 2016-06-07 19:30:06 +0000
3+++ src/platforms/mirserver/miropenglcontext.cpp 2016-11-18 15:00:52 +0000
4@@ -179,7 +179,14 @@
5 }
6 }
7
8+#if QT_VERSION < QT_VERSION_CHECK(5, 7, 0)
9 QFunctionPointer MirOpenGLContext::getProcAddress(const QByteArray &procName)
10 {
11 return eglGetProcAddress(procName.constData());
12 }
13+#else
14+QFunctionPointer MirOpenGLContext::getProcAddress(const char *procName)
15+{
16+ return eglGetProcAddress(procName);
17+}
18+#endif
19
20=== modified file 'src/platforms/mirserver/miropenglcontext.h'
21--- src/platforms/mirserver/miropenglcontext.h 2016-05-06 08:31:13 +0000
22+++ src/platforms/mirserver/miropenglcontext.h 2016-11-18 15:00:52 +0000
23@@ -44,7 +44,11 @@
24
25 bool isSharing() const override { return false; }
26
27+#if QT_VERSION < QT_VERSION_CHECK(5, 7, 0)
28 QFunctionPointer getProcAddress(const QByteArray &procName) override;
29+#else
30+ QFunctionPointer getProcAddress(const char *procName) override;
31+#endif
32
33 #ifdef QGL_DEBUG
34 Q_SLOT void onGlDebugMessageLogged(QOpenGLDebugMessage m) { qDebug() << m; }
35
36=== modified file 'tests/mirserver/Screen/screen_test.cpp'
37--- tests/mirserver/Screen/screen_test.cpp 2016-02-15 16:02:18 +0000
38+++ tests/mirserver/Screen/screen_test.cpp 2016-11-18 15:00:52 +0000
39@@ -22,6 +22,8 @@
40
41 #include <screen.h>
42
43+#include <QSensorManager>
44+
45 using namespace ::testing;
46
47 namespace mg = mir::graphics;
48@@ -37,6 +39,12 @@
49 if (!qEnvironmentVariableIsSet("QT_ACCEL_FILEPATH")) {
50 // Trick Qt >= 5.4.1 to load the generic sensors
51 qputenv("QT_ACCEL_FILEPATH", "dummy");
52+ // Tell Qt >= 5.7 to use the generic orientation sensor
53+ // since the proper linux one is not always running
54+ // in test environments making the test fail
55+ if (QSensorManager::isBackendRegistered("QOrientationSensor", "iio-sensor-proxy.orientationsensor")) {
56+ QSensorManager::unregisterBackend("QOrientationSensor", "iio-sensor-proxy.orientationsensor");
57+ }
58 }
59
60 Screen::skipDBusRegistration = true;
61
62=== modified file 'tests/mirserver/ScreensModel/CMakeLists.txt'
63--- tests/mirserver/ScreensModel/CMakeLists.txt 2016-09-07 09:23:54 +0000
64+++ tests/mirserver/ScreensModel/CMakeLists.txt 2016-11-18 15:00:52 +0000
65@@ -23,6 +23,8 @@
66
67 add_executable(ScreensModelTest ${SCREENCONTROLLER_TEST_SOURCES})
68
69+set_property(TARGET ScreensModelTest PROPERTY CXX_STANDARD 14)
70+
71 target_link_libraries(
72 ScreensModelTest
73 qpa-mirserver-nolttng

Subscribers

People subscribed via source and target branches