Merge lp:~aacid/qtmir/bringBackR538 into lp:qtmir

[Albert Astals Cid]

Bring back r538

It seems we may have a workaround in unity8 so that way we get the speed benefit of this change

 * Are there any related MPs required for this MP to build/function as expected?
https://code.launchpad.net/~mterry/unity8/greeter-keep-alive-emergency/+merge/304101

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Not yet, will do with silo

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:566
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/389/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3023
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3051
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2908/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/389/rebuild

review: Approve (continuous-integration)

[Gerry Boland (gerboland)]

If it is indeed worked around, then great. The crash this caused was deep in Qt, I hope you're right!

review: Approve

[Albert Astals Cid (aacid)]

Note the depending MR is not ready yet.

[Albert Astals Cid (aacid)]

I'll put this to Work in Progress to clear the "accepted" queue since it seems that the prerequisite branch is not being worked on for the moment.

Unmerged revisions

566. By Albert Astals Cid on 2016-09-30

Bring back r538

It seems we may have a workaround in unity8 so that way we get the speed benefit of this change

=== modified file 'src/modules/Unity/Application/application_manager.cpp'
--- src/modules/Unity/Application/application_manager.cpp	2016-08-26 09:08:55 +0000
+++ src/modules/Unity/Application/application_manager.cpp	2016-09-30 11:21:36 +0000
@@ -87,9 +87,8 @@
     // (blocking) event for authorizeSession is pushed on the same queue - so the application's processState
     // will be up-to-date when authorizeSession is called.
     //
-    // TODO: Unfortunately making this queued unearths a crash (likely in Qt) (LP: #1616842).
     QObject::connect(controller, &TaskController::processStarting,
-                     manager, &ApplicationManager::onProcessStarting);
+                     manager, &ApplicationManager::onProcessStarting, Qt::QueuedConnection);
 
     QObject::connect(controller, &TaskController::processStopped,
                      manager, &ApplicationManager::onProcessStopped);