Merge lp:~aacid/qmenumodel/disabledMenus into lp:qmenumodel

Proposed by Albert Astals Cid
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 131
Merged at revision: 131
Proposed branch: lp:~aacid/qmenumodel/disabledMenus
Merge into: lp:qmenumodel
Prerequisite: lp:~aacid/qmenumodel/aboutToShow
Diff against target: 22 lines (+11/-1)
1 file modified
libqmenumodel/src/gtk/gtkmenutrackeritem.c (+11/-1)
To merge this branch: bzr merge lp:~aacid/qmenumodel/disabledMenus
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
Review via email: mp+319286@code.launchpad.net

Commit message

Use submenu-enabled for those items that don't have an action (if it exists)

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM, looks good and works fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libqmenumodel/src/gtk/gtkmenutrackeritem.c'
2--- libqmenumodel/src/gtk/gtkmenutrackeritem.c 2015-04-30 14:35:09 +0000
3+++ libqmenumodel/src/gtk/gtkmenutrackeritem.c 2017-03-08 09:25:40 +0000
4@@ -469,7 +469,17 @@
5 g_variant_unref (state);
6 }
7 else
8- self->sensitive = TRUE;
9+ {
10+ gboolean submenu_enabled;
11+ if (g_menu_item_get_attribute (self->item, "submenu-enabled", "b", &submenu_enabled))
12+ {
13+ self->sensitive = submenu_enabled;
14+ }
15+ else
16+ {
17+ self->sensitive = TRUE;
18+ }
19+ }
20
21 return self;
22 }

Subscribers

People subscribed via source and target branches