Merge lp:~aacid/platform-api/do_not_complain_invalid_option into lp:platform-api

[Albert Astals Cid]

Remove spurious warnings about invalid option when parsing command line arguments

[lp:~aacid/platform-api/do_not_complain_invalid_option]

325. By Albert Astals Cid on 2016-06-09

explain what opterr is

[Gerry Boland (gerboland)]

review: Approve

=== modified file 'src/ubuntu/application/common/mirclient/application_options_mir.cpp'
--- src/ubuntu/application/common/mirclient/application_options_mir.cpp	2015-06-18 00:36:42 +0000
+++ src/ubuntu/application/common/mirclient/application_options_mir.cpp	2016-06-09 17:50:50 +0000
@@ -30,6 +30,11 @@
 
 #include <unistd.h>
 
+// opterr is a extern variable exported by glibc that
+// controls whether getopt prints warnings on unknown options
+// see 'man opterr'
+extern int opterr;
+
 namespace uam = ubuntu::application::mir;
 
 UApplicationOptions* uam::Options::as_u_application_options()
@@ -112,6 +117,10 @@
         }
     }
 
+    // Do not complain about options we don't know
+    // the app may have other params
+    int orig_opterr = opterr;
+    opterr = 0;
     while(true)
     {
         int option_index = 0;
@@ -147,6 +156,7 @@
             break;
         }
     }
+    opterr = orig_opterr;
     
     return app_options->as_u_application_options();
 }