Merge lp:~aacid/phablet-tools/apt-get-update-for-install-packages into lp:phablet-tools

Proposed by Albert Astals Cid
Status: Merged
Merged at revision: 351
Proposed branch: lp:~aacid/phablet-tools/apt-get-update-for-install-packages
Merge into: lp:phablet-tools
Diff against target: 15 lines (+4/-1)
1 file modified
phablet-config (+4/-1)
To merge this branch: bzr merge lp:~aacid/phablet-tools/apt-get-update-for-install-packages
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+276400@code.launchpad.net

Commit message

apt-get update too when installing packages

Otherwise if this is the first time that phablet-config writable-image is called on a clean phone
apt-get update has never been run and the packages won't be found

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

I don't really understand why this is necessary (or why run_on_device.sh looks like it's compiling unity8 on your phone) but I'll just approve it anyway and if anybody complains I'll blame you.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-config'
2--- phablet-config 2014-09-23 17:19:12 +0000
3+++ phablet-config 2015-11-02 15:09:55 +0000
4@@ -206,7 +206,10 @@
5 for ppa in args.ppa:
6 sudo_shell(adb, sudocmd, 'add-apt-repository -y %s' % ppa)
7
8- if args.package_dir or args.ppa:
9+ if args.package_dir or args.ppa or args.package:
10+ if not is_remote_root(adb) and not args.remotepassword:
11+ print('need the remote password (-r) for package operations')
12+ sys.exit(1)
13 sudo_shell(adb, sudocmd, 'apt-get update -qq')
14
15 if args.package:

Subscribers

People subscribed via source and target branches