Merge lp:~aacid/mir/fix_forward_declarations into lp:mir

[Albert Astals Cid]

Fix forward declarations so that qtmir can be built with clang

[Alan Griffiths (alan-griffiths)]

I think this attempt is misguided and that you should use -Wno-mismatched-tags in qtmir.

/1/ According to the language standard there are no differences between "struct" and "class" in this (declaration) context. The only differences are in the context of definitions (of which there will only be one. So the warning is pointless.

/2/ We did try to keep clang happy for a while on Mir, but eventually ran into some standard library types that were declared "struct" in some headers and "class" in others. So problems existed outside code that we control.

So there's no advantage to using this warning, and a definite cost.

review: Abstain

[Alan Griffiths (alan-griffiths)]

> So problems existed outside code that we control.

So using the warning introduces problems existed outside code that we control.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2975
http://jenkins.qa.ubuntu.com/job/mir-ci/5058/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3083
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4118
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/76/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1209
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1209/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/76/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4119
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4119/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/6799
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23760
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/77/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5058/rebuild

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

Huh. I remember a couple of years back we fixed these because clang complained about them. No idea why clang had't complained again till now.

review: Approve

[Alan Griffiths (alan-griffiths)]

> Huh. I remember a couple of years back we fixed these because clang complained
> about them. No idea why clang had't complained again till now.

We added "-Wno-mismatched-tags" because of 3rd party code that (correctly, according to the language) doesn't care about this distinction.

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/1920/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4141
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/99/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/475/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/99/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4142
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4142/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/6818
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23808
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/100/console

review: Needs Fixing (continuous-integration)

[Alan Griffiths (alan-griffiths)]

AFAICS landing problem was fixed by lp:~mir-team/mir/workaround-for-valgrind-opcode

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'include/server/mir/compositor/display_listener.h'
--- include/server/mir/compositor/display_listener.h	2015-02-27 14:29:18 +0000
+++ include/server/mir/compositor/display_listener.h	2015-09-29 13:35:37 +0000
@@ -21,7 +21,7 @@
 
 namespace mir
 {
-namespace geometry { class Rectangle; }
+namespace geometry { struct Rectangle; }
 namespace compositor
 {
 class DisplayListener

=== modified file 'include/server/mir/frontend/buffer_stream.h'
--- include/server/mir/frontend/buffer_stream.h	2015-09-15 18:25:38 +0000
+++ include/server/mir/frontend/buffer_stream.h	2015-09-29 13:35:37 +0000
@@ -29,7 +29,7 @@
 namespace graphics
 {
 class Buffer;
-class BufferProperties;
+struct BufferProperties;
 }
 namespace scene
 {

=== modified file 'include/server/mir/frontend/session.h'
--- include/server/mir/frontend/session.h	2015-04-28 07:54:10 +0000
+++ include/server/mir/frontend/session.h	2015-09-29 13:35:37 +0000
@@ -31,7 +31,7 @@
 namespace graphics
 {
 class DisplayConfiguration;
-class BufferProperties;
+struct BufferProperties;
 }
 
 namespace frontend

=== modified file 'include/server/mir/shell/focus_controller.h'
--- include/server/mir/shell/focus_controller.h	2015-06-17 05:20:42 +0000
+++ include/server/mir/shell/focus_controller.h	2015-09-29 13:35:37 +0000
@@ -24,7 +24,7 @@
 
 namespace mir
 {
-namespace geometry { class Point; }
+namespace geometry { struct Point; }
 namespace scene { class Session; class Surface; }
 
 namespace shell

=== modified file 'include/server/mir/shell/shell.h'
--- include/server/mir/shell/shell.h	2015-06-17 05:20:42 +0000
+++ include/server/mir/shell/shell.h	2015-09-29 13:35:37 +0000
@@ -31,7 +31,7 @@
 namespace mir
 {
 namespace frontend { class EventSink; }
-namespace geometry { class Rectangle; }
+namespace geometry { struct Rectangle; }
 namespace scene
 {
 class PromptSession;

=== modified file 'include/server/mir/shell/window_manager.h'
--- include/server/mir/shell/window_manager.h	2015-06-17 05:20:42 +0000
+++ include/server/mir/shell/window_manager.h	2015-09-29 13:35:37 +0000
@@ -27,11 +27,11 @@
 
 namespace mir
 {
-namespace geometry { class Rectangle; }
-namespace scene { class Session; class Surface; class SurfaceCreationParameters; }
+namespace geometry { struct Rectangle; }
+namespace scene { class Session; class Surface; struct SurfaceCreationParameters; }
 namespace shell
 {
-class SurfaceSpecification;
+struct SurfaceSpecification;
 
 /// interface to provide window management logic
 class WindowManager