Merge lp:~aacid/gsettings-qt/use_qchar_upper_lower into lp:gsettings-qt

[Albert Astals Cid]

Use QChar toUpper/toLower instead of C version

C version works according to the locale that is not what we want in here
since in some locales there's not capital versions for some of the latin1
characters (i.e. Turkish will return i for toupper('i')) so when we try to
go back to the dashed version it will fail

[Michael Zanetti (mzanetti)]

lgtm

review: Approve

[Nick Dedekind (nick-dedekind)]

review: Needs Fixing

[lp:~aacid/gsettings-qt/use_qchar_upper_lower]

81. By Albert Astals Cid on 2016-03-21

Use also the qchar isUpper for completeness

[Nick Dedekind (nick-dedekind)]

LGTM

review: Approve

=== modified file 'src/util.cpp'
--- src/util.cpp	2013-08-06 13:08:22 +0000
+++ src/util.cpp	2016-03-21 10:03:13 +0000
@@ -32,7 +32,7 @@
         if (*name == '-') {
             next_cap = true;
         } else if (next_cap) {
-            result.append(toupper(*name));
+            result.append(QChar(*name).toUpper().toLatin1());
             next_cap = false;
         } else {
             result.append(*name);
@@ -61,9 +61,10 @@
     str = g_string_new (NULL);
 
     for (p = bytes.constData(); *p; p++) {
-        if (isupper(*p)) {
+        const QChar c(*p);
+        if (c.isUpper()) {
             g_string_append_c (str, '-');
-            g_string_append_c (str, tolower(*p));
+            g_string_append_c (str, c.toLower().toLatin1());
         }
         else {
             g_string_append_c (str, *p);