Code review comment for lp:~aacid/compiz/do_not_change_viewport_on_resize

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Reviewed and tested again. It looks correct and fixes the bug.

Although the relevant logic is a prime candidate for automated testing, the relevant classes are not yet isolated enough to be unit-testable. And doing so in src/window.cpp is a risky proposition.

review: Approve

« Back to merge proposal