Merge lp:~aacid/autopilot/keyboard_when_needed into lp:autopilot/1.5

[Albert Astals Cid]

Do not create a keyboard until needed

Otherwise unity8 won't show the OSK because it thinks there's a physical keyboard attached.

[lp:~aacid/autopilot/keyboard_when_needed]

518. By Albert Astals Cid on 2015-08-18

Do not create a keyboard until needed

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:518
http://jenkins.qa.ubuntu.com/job/autopilot-1.5-ci/36/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-wily-amd64-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-wily-armhf-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-wily-i386-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-1.5-ci/36/rebuild

review: Needs Fixing (continuous-integration)

[Christopher Lee (veebers)]

Hi Albert, Thanks for this. I'll take care of the CI failures (just pushing that branch now to fix flake8). Unfortunately we have a bit of a convoluted branch/release process where we develop (and merge into) on lp:autopilot and when we release using the train propose against lp:autopilot/1.5.

I can take these changes and put it through this process and deprecate this branch. Sorry for the confusion.

[Christopher Lee (veebers)]

FYI new branch is here: https://code.launchpad.net/~canonical-platform-qa/autopilot/create-keyboard-when-first-requested/+merge/268423

Unmerged revisions

518. By Albert Astals Cid on 2015-08-18

Do not create a keyboard until needed

=== modified file 'autopilot/testcase.py'
--- autopilot/testcase.py	2015-07-15 23:31:12 +0000
+++ autopilot/testcase.py	2015-08-18 12:45:18 +0000
@@ -163,7 +163,7 @@
         self._process_manager = None
         self._mouse = None
         self._display = None
-        self._kb = Keyboard.create()
+        self._kb = None
 
         # Instatiate this after keyboard creation to ensure it doesn't get
         # overwritten
@@ -191,6 +191,8 @@
 
     @property
     def keyboard(self):
+        if self._kb is None:
+            self._kb = Keyboard.create()
         return self._kb
 
     @property