lp:~a1s/qbrz/fix-argument-types

Created by Aleksandr Smyshliaev and last modified
Get this branch:
bzr branch lp:~a1s/qbrz/fix-argument-types
Only Aleksandr Smyshliaev can upload to this branch. If you are Aleksandr Smyshliaev please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Aleksandr Smyshliaev
Project:
qbrz
Status:
Merged

Recent revisions

1643. By Aleksandr Smyshliaev

Fix syncing horizontal sliders in diffview

1642. By Aleksandr Smyshliaev

Fix passing arguments of invalid type.

1641. By Jelmer Vernooij

Improve Breezy 3.2 compatibility.

1640. By Robert Ladyman

Tried to fix add... works in pyqt4 but not pyqt5, who knows why? Not me. Left it for now.

1639. By Robert Ladyman

Corrected _triggered / triggered calls for PyQt5 in browse.py. Stand-alone qbrowse still has problems but works reasonably well when called from (say) qlog. Removed @runs_in_loading_queue.

Note that TreeWidget::restore_state has a note from 2009 that restore_state does not work for sub-items. Seems to still not do so.

1638. By Robert Ladyman

Reverted singleShot to 0 (removal of decorator for backgrounding fixed this). Call super().show() instead of QBzrWindow.show(self).

1637. By Robert Ladyman

Removed @runs_in_loading_queue from log.py load() - now runs like the clappers and works correctly. Corrected elided_text in logwidget.

1636. By Robert Ladyman

Changed QTimer.singleShot(0... to 1 - behaviour of Qt5 seems to differ. The docs state (for Qt5):-

As a special case, a QTimer with a timeout of 0 will time out as soon as possible, though the ordering between zero timers and other sources of events is unspecified. Zero timers can be used to do some work while still providing a snappy user interface...

However, what actually happens (with QBrz) is that the shot only occurs when something else actually happens (a mouse-click, moving a window, a click outside QBrz, etc.)

1635. By Robert Ladyman

Reverted to 1632 as 1633 and 1634 cause major issues with test suite. Incorporated jelmers setup.py change

1634. By Robert Ladyman

qbrowse still has problems - deferred for now: added comments with note of problem.
Fixed hexdump in lib/cat.py to handle bytes (well... force them to string, heh!).
Tidied up some spacing issues / line-breaks and spurious semicolons. Noted problem with diff.triggered sometimes receiving bools instead of strings / None (although not sure it should NOT receive bools - impossible to tell).
Noted issue with TreeWidget and ChangeDesc: I suspect changes in Breezy have not been properly transferred to QBrz (naughty me - needs full review when I get time).
uifactory.py @current_widget raises a TypeError if there are no parameters for the passed method: the change to r = f(args[0]) did not help, however.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:qbrz
This branch contains Public information 
Everyone can see this information.