Merge lp:~a-volkov/qpdfview/send_by_email_1 into lp:qpdfview

[Alexander Volkov]

Add "Send by Email" action

[Adam Reichold (adamreichold)]

Thank you for your contribution! The change looks good to me, except for the minor nits detailed inline with the diff.

review: Needs Fixing

[Adam Reichold (adamreichold)]

review: Approve

[Adam Reichold (adamreichold)]

I merged this into trunk revision 2133. It did not work for me using Thunderbird though: While an URL like "mailto:?attach=/absolute/path/to/file.pdf" was generated, this did not make Thunderbird actually attach the file.

[Alexander Volkov (a-volkov)]

xdg-email treats thunderbird as a special case: https://gitlab.freedesktop.org/xdg/xdg-utils/-/blob/master/scripts/xdg-email.in#L33
It should run thunderbird by the command line "thunderbird -compose attachment='path/to/file.pdf'"
Probably in your case xdg-email decided that thunderbird is not thunderbird.

=== modified file 'sources/mainwindow.cpp'
--- sources/mainwindow.cpp	2021-04-23 08:00:48 +0000
+++ sources/mainwindow.cpp	2021-08-13 12:54:39 +0000
@@ -596,6 +596,7 @@
 
     m_refreshAction->setEnabled(hasCurrent);
     m_printAction->setEnabled(hasCurrent);
+    m_emailAction->setEnabled(hasCurrent);
 
     m_previousPageAction->setEnabled(hasCurrent);
     m_nextPageAction->setEnabled(hasCurrent);
@@ -1579,6 +1580,11 @@
     }
 }
 
+void MainWindow::on_email_triggered()
+{
+    QProcess::startDetached(QLatin1String("xdg-email"), QStringList() << QLatin1String("--attach") << currentTab()->fileInfo().absoluteFilePath());
+}
+
 void MainWindow::on_recentlyUsed_openTriggered(const QString& filePath)
 {
     if(!jumpToPageOrOpenInNewTab(filePath, -1, true))
@@ -3188,6 +3194,15 @@
     m_saveAsAction = createAction(tr("Save &as..."), QLatin1String("saveAs"), QLatin1String("document-save-as"), QKeySequence::SaveAs, SLOT(on_saveAs_triggered()));
     m_saveCopyAction = createAction(tr("Save &copy..."), QLatin1String("saveCopy"), QIcon(), QKeySequence(), SLOT(on_saveCopy_triggered()));
     m_printAction = createAction(tr("&Print..."), QLatin1String("print"), QLatin1String("document-print"), QKeySequence::Print, SLOT(on_print_triggered()));
+    m_emailAction = createAction(tr("Send by &e-mail..."), QLatin1String("email"), QLatin1String("mail-send"), QList<QKeySequence>(), SLOT(on_email_triggered()));
+
+    m_emailAction->setVisible(
+#if QT_VERSION >= QT_VERSION_CHECK(5,0,0)
+        !QStandardPaths::findExecutable(QLatin1String("xdg-email")).isEmpty()
+#else
+        false
+#endif
+    );
     m_exitAction = createAction(tr("E&xit"), QLatin1String("exit"), QIcon::fromTheme("application-exit"), QKeySequence::Quit, SLOT(close()));
     m_exitAction->setMenuRole(QAction::QuitRole);
 
@@ -3539,7 +3554,7 @@
         setToolButtonMenu(m_fileToolBar, m_openInNewTabAction, m_recentlyUsedMenu);
     }
 
-    m_fileMenu->addActions(QList< QAction* >() << m_refreshAction << m_saveAction << m_saveAsAction << m_saveCopyAction << m_printAction);
+    m_fileMenu->addActions(QList< QAction* >() << m_refreshAction << m_saveAction << m_saveAsAction << m_saveCopyAction << m_printAction << m_emailAction);
     m_fileMenu->addSeparator();
     m_fileMenu->addAction(m_exitAction);
 

=== modified file 'sources/mainwindow.h'
--- sources/mainwindow.h	2021-04-23 08:00:48 +0000
+++ sources/mainwindow.h	2021-08-13 12:54:39 +0000
@@ -166,6 +166,7 @@
     void on_saveAs_triggered();
     void on_saveCopy_triggered();
     void on_print_triggered();
+    void on_email_triggered();
 
     void on_recentlyUsed_openTriggered(const QString& filePath);
 
@@ -369,6 +370,7 @@
     QAction* m_saveAsAction;
     QAction* m_saveCopyAction;
     QAction* m_printAction;
+    QAction* m_emailAction;
     QAction* m_exitAction;
 
     QAction* m_previousPageAction;