Merge lp:~a-s-usov/python-fastimport/partial-streams-filtering into lp:~registry/python-fastimport/old
Proposed by
Alex Usov
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 304 | ||||
Proposed branch: | lp:~a-s-usov/python-fastimport/partial-streams-filtering | ||||
Merge into: | lp:~registry/python-fastimport/old | ||||
Diff against target: |
301 lines (+240/-5) 2 files modified
fastimport/processors/filter_processor.py (+11/-3) fastimport/tests/test_filter_processor.py (+229/-2) |
||||
To merge this branch: | bzr merge lp:~a-s-usov/python-fastimport/partial-streams-filtering | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | code | Approve | |
Review via email: mp+80034@code.launchpad.net |
This proposal supersedes a proposal from 2011-10-20.
Description of the change
Parameter renamed, few more tests with includes/excludes added
To post a comment you must log in.
Hi,
Thanks for working on this.
I think "preserve_ all_history" is a confusing name for this new behaviour. You're still changing history, just not removing commits.
Perhaps a better would be "squash_ empty_commits" , which could default to true?
Can you please also add a test that uses excludes/includes and filters? I suspect that if there are blobs that are removed, this will change the allocation of new ids, and might break the rewriting of from lines.
+ * preserve_ all_history - if True filter processeor will be much more conservative processor/
s/processeor/