Merge lp:~a-lown0/wizardpen/gpen into lp:wizardpen
Proposed by
Ali Lown
Status: | Merged |
---|---|
Merged at revision: | 24 |
Proposed branch: | lp:~a-lown0/wizardpen/gpen |
Merge into: | lp:wizardpen |
Diff against target: |
98 lines (+65/-0) 2 files modified
src/wizardpen.c (+59/-0) src/wizardpen.h (+6/-0) |
To merge this branch: | bzr merge lp:~a-lown0/wizardpen/gpen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerard Krol | Approve | ||
Review via email: mp+21813@code.launchpad.net |
Description of the change
Re-made this branch so that it is a direct branch from wizardpen.
Hopefully this will make the merge a bit easier to see.
To post a comment you must log in.
[quote]Would it also work if you only suppress the button event, but still update the pressure status?[/quote]
Would, but there is no point. The reason pressure gets disabled is because the F509 sends pressure events which were making the computer think a left-click whenever one of the side buttons (which are mapped to middle/right-click) were pressed.
[quote]Also, the "//HACK, do avoid having to do conditional sections depending on tablet type" is a bit scary. I'd rather prefer a configuration option like "AlwaysTapToClick" that would only send standard clicks when none of the buttons is pressed, and sends the other buttons when you tap.[/quote]
I don't understand quite what you are saying this option should do. The 'HACK' is clearing of the middle click event because some click patterns (due to the re-use of the BTN_TOUCH event for when the stylus tip is pressed) would prevent the un-set event from being sent.
Also: would it be worth adding 2 options to enable the user to choose the event sent for each button (rather than hard-coding in middle/ right-clicks) ?