Merge lp:~3v1n0/unity8/calendar-day-selection into lp:unity8
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 2480 |
Merged at revision: | 2671 |
Proposed branch: | lp:~3v1n0/unity8/calendar-day-selection |
Merge into: | lp:unity8 |
Prerequisite: | lp:~3v1n0/unity8/menuitems-slots-cleanup |
Diff against target: |
116 lines (+31/-8) 4 files modified
debian/control (+3/-3) plugins/Unity/Indicators/modelprinter.cpp (+19/-4) plugins/Unity/Indicators/modelprinter.h (+2/-1) qml/Panel/Indicators/MenuItemFactory.qml (+7/-0) |
To merge this branch: | bzr merge lp:~3v1n0/unity8/calendar-day-selection |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Albert Astals Cid (community) | Abstain | ||
Lukáš Tinkl (community) | Approve | ||
Ubuntu Unity PS integration team | Pending | ||
Review via email:
|
Commit message
MenuItemFactory: activate item on calendar selection change
This informs the indicator-datetime to update the list of the upcoming events
Description of the change
Prereq-archive: ppa:ci-
Making day selection work in the calendar, some features in the linked bug are depeneding on new design instead.
* Are there any related MPs required for this MP to build/function as expected? Please list.
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Done
* If you changed the UI, has there been a design review?
N/A
FAILED: Continuous integration, rev:2475 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/2386/ /unity8- jenkins. ubuntu. com/job/ build/3137/ console /unity8- jenkins. ubuntu. com/job/ build-0- fetch/3165 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 3021/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= yakkety/ 3021/console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/2386/ rebuild
https:/