Unity

Merge lp:~3v1n0/unity/unity7-wants-ups into lp:unity

  1. unity7-wants-ups
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4225
Proposed branch: lp:~3v1n0/unity/unity7-wants-ups
Merge into: lp:unity
Diff against target: 11 lines (+1/-2)
1 file modified
data/unity7.service.in (+1/-2)
To merge this branch: bzr merge lp:~3v1n0/unity/unity7-wants-ups
Reviewer Review Type Date Requested Status
Iain Lane Approve
Unity Team Pending
Review via email: mp+318517@code.launchpad.net

Commit message

unity7.service: set ups and BAMF as wanted, not required

We don't want unity to crash when they do.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

01/03 09:32:31 <Laney> Trevinho: should be RequiredBy=ubuntu-session.target, no?
01/03 09:32:45 <Laney> the session itself isn't valid without unity7, but unity7 is (arguably) valid without those other things

Fix this one as you prefer

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

This is what we have now

laney@nightingale> ls ubuntu-session.target.requires
unity7.service@
laney@nightingale> ls ubuntu-session.target.wants
unity-gtk-module.service@ unity-settings-daemon.service@ window-stack-bridge.service@

I think that's pretty good. In fact it means that you could drop u-s-d from Wants= completely in this MP, since it is responsible for starting itself up.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/unity7.service.in'
2--- data/unity7.service.in 2016-09-05 10:48:28 +0000
3+++ data/unity7.service.in 2017-03-01 11:34:07 +0000
4@@ -1,7 +1,6 @@
5 [Unit]
6 Description=Unity Shell v7
7-Requires=unity-settings-daemon.service unity-panel-service.service bamfdaemon.service
8-Wants=unity-gtk-module.service
9+Wants=unity-settings-daemon.service unity-gtk-module.service unity-panel-service.service bamfdaemon.service
10 After=unity-settings-daemon.service
11 PartOf=graphical-session.target
12