lp:~3v1n0/unity/testing-friend

Branch merges

Propose for merging

Rejected for merging into lp:unity

Andrea Azzarone (community): Disapprove on 2013-01-30

Brandon Schaefer (community): Needs Fixing on 2012-08-27

Francis Ginther: Abstain on 2012-08-01

jenkins (community): Needs Fixing (continuous-integration) on 2012-07-26

Diff: 569 lines (+275/-76)

7 files modified

launcher/EdgeBarrierController.cpp (+1/-41)
launcher/EdgeBarrierController.h (+3/-3)
launcher/EdgeBarrierControllerPrivate.h (+68/-0)
launcher/LauncherController.h (+2/-2)
tests/test_edge_barrier_controller.cpp (+34/-28)
tests/test_launcher_controller.cpp (+12/-2)
unity-shared/TestingFriend.h (+155/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2558. By Marco Trevisan (Treviño) on 2012-07-25

Merging with lp:~3v1n0/unity/launcher-controller-ensure-new (and trunk)

2557. By Marco Trevisan (Treviño) on 2012-07-25

test_edge_barrier_controller: use tests::Friend

2556. By Marco Trevisan (Treviño) on 2012-07-25

EdgeBarrierController: move the definition of ::Impl in EdgeBarrierControllerPrivate

For testing purposes...

2555. By Marco Trevisan (Treviño) on 2012-07-25

LauncherController: use unity::tests::Friend to access to pimpl!

2554. By Marco Trevisan (Treviño) on 2012-07-25

TestingFriend: added testing friend, a tool that will help you in testing!

2553. By Marco Trevisan (Treviño) on 2012-07-25

test_launcher_controller: more barrier subscriptions tests

2552. By Marco Trevisan (Treviño) on 2012-07-25

test_launcher_controller: check the barrier controller subscriptions

2551. By Marco Trevisan (Treviño) on 2012-07-25

LauncherController: make TestLauncherController friend of it

2550. By Marco Trevisan (Treviño) on 2012-07-25

EdgeBarrierController: make GetSubscriber public

2549. By Marco Trevisan (Treviño) on 2012-07-25

LauncherController: move launcher::Controller::Impl definition in LauncherControllerPrivate

So that we can test it!