Merge lp:~3v1n0/unity/sticky-save-fix into lp:unity

[Marco Trevisan (Treviño)]

BamfLauncherIcon: call Stick after that the icon is set sticky, so that the signal emission will work

And so the favorites will be correctly saved.

A BamfLauncherIcon needs to call the SimpleLauncherIcon::Stick as last thing, since if this won't happen, when the position_saved signal is emitted, IsSticky() call would still return false and then the icon would not been added to the favorite store.

Unit tests updated.

[Andrea Azzarone (azzar1)]

Works here.

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1404/console reported an error when processing this lp:~3v1n0/unity/sticky-save-fix branch.
Not merging it.

=== modified file 'launcher/BamfLauncherIcon.cpp'
--- launcher/BamfLauncherIcon.cpp	2012-09-25 23:09:59 +0000
+++ launcher/BamfLauncherIcon.cpp	2012-09-28 14:59:29 +0000
@@ -935,12 +935,12 @@
 
 void BamfLauncherIcon::Stick(bool save)
 {
+  if (IsSticky())
+    return;
+
+  bamf_view_set_sticky(BAMF_VIEW(_bamf_app.RawPtr()), true);
+
   SimpleLauncherIcon::Stick(save);
-
-  if (IsSticky())
-    return;
-
-  bamf_view_set_sticky(BAMF_VIEW(_bamf_app.RawPtr()), true);
 }
 
 void BamfLauncherIcon::UnStick()

=== modified file 'tests/test_launcher_controller.cpp'
--- tests/test_launcher_controller.cpp	2012-09-20 00:14:30 +0000
+++ tests/test_launcher_controller.cpp	2012-09-28 14:59:29 +0000
@@ -163,14 +163,6 @@
       return FavoriteStore::URI_PREFIX_APP + remote_uri_;
   }
 
-  bool IsSticky() const
-  {
-    if (remote_uri_.empty())
-      return BamfLauncherIcon::IsSticky();
-    else
-      return SimpleLauncherIcon::IsSticky();
-  }
-
   void ReallyStick(bool save) { BamfLauncherIcon::Stick(save); }
 
   MOCK_METHOD1(Stick, void(bool));