Merge lp:~3v1n0/unity/spread-title-flicker-fix into lp:unity

[Marco Trevisan (Treviño)]

PluginAdapter: set the spread window state before spreading or the callback will get a wrong state

Set the state variable before actually spreading or the callback
functions will have a wrong value for IsScaleActiveForGroup

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3567
http://jenkins.qa.ubuntu.com/job/unity-ci/434/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/323
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/321
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/322

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-ci/434/rebuild

review: Approve (continuous-integration)

[Christopher Townsend (townsend)]

Nice. +1

Will wait to globally approve until we here from Stephen.

review: Approve

[Christopher Townsend (townsend)]

Since this is for 7.1 as well, then globally approving.

[Marco Trevisan (Treviño) (3v1n0)]

Rejecting, as this is already in.

=== modified file 'unity-shared/PluginAdapter.cpp'
--- unity-shared/PluginAdapter.cpp	2013-09-14 09:56:10 +0000
+++ unity-shared/PluginAdapter.cpp	2013-10-11 12:04:43 +0000
@@ -972,9 +972,9 @@
   std::size_t num_windows = windows.size();
   if (num_windows > 1 || (force && num_windows))
   {
+    _spread_windows_state = true;
     std::string const& match = MatchStringForXids(windows);
     InitiateScale(match, state);
-    _spread_windows_state = true;
     return true;
   }
   return false;